Make some fatal lexer errors recoverable #33199
Conversation
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -27,26 +27,47 @@ pub use ext::tt::transcribe::{TtReader, new_tt_reader, new_tt_reader_with_doc_fl | |||
| pub mod comments; | |||
| mod unicode_chars; | |||
|
|
|||
| pub type TokenAndSpanResult = Result<TokenAndSpan, ()>; | |||
There was a problem hiding this comment.
This doesn't seem worth making a type for, it only saves a few chars.
|
There are some small things to change inline, r+ with those fixed. |
mitaa
force-pushed
the
tokenize-responsibly
branch
from
ed6c1f9 to
d420225
Compare
|
I tried using a closure, but that didn't really work out. Passing just the result to I've also added a note to the rustdoc warning. |
mitaa
force-pushed
the
tokenize-responsibly
branch
2 times, most recently
from
6cf22db to
38b45dd
Compare
| // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
There was a problem hiding this comment.
Could you add a comment to this test explaining what is being tested please?
|
@mitaa thanks for the changes and explanation, I have one more very minor request (sorry I missed it the first time round), then r+ for reals. |
mitaa
force-pushed
the
tokenize-responsibly
branch
from
38b45dd to
6887202
Compare
|
(updated) |
|
@bors: r+ |
|
📌 Commit 6887202 has been approved by |
I've kept the changes to a minimum since I'm not really sure if this approach is a acceptable.
fixes #12834
cc @nrc