Fix several -Z orbit crater blockers. #33488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
added
the
S-waiting-on-crater
|
@nikomatsakis Could you try crater + |
|
@eddyb done. |
|
@bors r+ |
|
📌 Commit cb3a557 has been approved by |
eddyb
removed
the
S-waiting-on-crater
|
Crater results, in case anyone cares. The only regression is just a (timeout) false positive. |
bors
added a commit
that referenced
this pull request
May 10, 2016
Fix several -Z orbit crater blockers. Fixes 3 of the issues found by @nikomatsakis' crater run with `-Z orbit` forced on: https://gist.github.com/nikomatsakis/6688c30a0e5d3fed07cc1ebd4efb1412 Two of the regressions seemed to be fixed by #33130 and the remaining two are timeouts.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 3 of the issues found by @nikomatsakis' crater run with
-Z orbitforced on:https://gist.github.com/nikomatsakis/6688c30a0e5d3fed07cc1ebd4efb1412
Two of the regressions seemed to be fixed by #33130 and the remaining two are timeouts.