Skip to content

Fix for old school error issues, improvements to new school #33688

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
May 19, 2016

Conversation

sophiajt
Copy link
Contributor

This PR:

r? @nikomatsakis

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented May 17, 2016

📌 Commit c1c1ad5 has been approved by nikomatsakis

@sanxiyn
Copy link
Member

sanxiyn commented May 18, 2016

@bors r-

This failed tidy.

@sophiajt
Copy link
Contributor Author

@bors r=nikomatsakis

@bors
Copy link
Collaborator

bors commented May 18, 2016

📌 Commit b0a317d has been approved by nikomatsakis

@bors
Copy link
Collaborator

bors commented May 19, 2016

⌛ Testing commit b0a317d with merge 0c5d651...

bors added a commit that referenced this pull request May 19, 2016
Fix for old school error issues, improvements to new school

This PR:
* Fixes some old school error issues, specifically #33559, #33543, #33366
* Improves wording borrowck errors with match patterns
* De-emphasize multi-line spans, so we don't color the single source character when we're trying to say "span starts here"
* Rollup of #33392 (which should help fix #33390)

r? @nikomatsakis
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spurious JSON parsing failure on bots
4 participants