-
Notifications
You must be signed in to change notification settings - Fork 13.4k
add more comprehensive tests for incr. comp. #33851
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
These tests reveal that the edges are in some cases too strict.
embed.x.x as u32 | ||
} | ||
|
||
#[rustc_dirty(label="TypeckItemBody", cfg="rpass2")] // FIXME(#33850) should be clean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting...
@bors r+ Do we have some documentation somewhere that describes the dependency graph node labels? I.e. how do we expect people to know that it's specifically |
📌 Commit fa64021 has been approved by |
There is no documentation aside from the code. But obviously these are unit On Tue, May 24, 2016 at 6:02 PM, Michael Woerister <notifications@github.com
|
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit fa64021 has been approved by |
Travis fails |
⌛ Testing commit fa64021 with merge 2367fc4... |
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
closing in favor of a new PR that incorporates a fix. |
Test various changes one can do to structs.
r? @michaelwoerister