Skip to content

add more comprehensive tests for incr. comp. #33851

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 2 commits into from

Conversation

nikomatsakis
Copy link
Contributor

Test various changes one can do to structs.

r? @michaelwoerister

embed.x.x as u32
}

#[rustc_dirty(label="TypeckItemBody", cfg="rpass2")] // FIXME(#33850) should be clean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting...

@michaelwoerister
Copy link
Member

@bors r+

Do we have some documentation somewhere that describes the dependency graph node labels? I.e. how do we expect people to know that it's specifically TypeckItemBody (for example) that should be invalidated by a given change?

@bors
Copy link
Collaborator

bors commented May 24, 2016

📌 Commit fa64021 has been approved by michaelwoerister

@nikomatsakis
Copy link
Contributor Author

There is no documentation aside from the code. But obviously these are unit
tests, so familiar with the code seems like a reasonable expectation to me.

On Tue, May 24, 2016 at 6:02 PM, Michael Woerister <notifications@github.com

wrote:

@bors https://github.com/bors r+

Do we have some documentation somewhere that describes the dependency
graph node labels? I.e. how do we expect people to know that it's
specifically TypeckItemBody (for example) that should be invalidated by a
given change?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#33851 (comment)

@bors
Copy link
Collaborator

bors commented May 25, 2016

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented May 25, 2016

📌 Commit fa64021 has been approved by nikomatsakis

@Manishearth
Copy link
Member

Travis fails

@bors
Copy link
Collaborator

bors commented May 29, 2016

⌛ Testing commit fa64021 with merge 2367fc4...

@bors
Copy link
Collaborator

bors commented May 29, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@nikomatsakis
Copy link
Contributor Author

closing in favor of a new PR that incorporates a fix.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants