derive Hash (and not Copy) for ranges #34180
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @sfackler |
|
This could do with some tests. |
|
Is there a reason you've not included |
|
@ollie27 no, it was a mistake. On Thu, Jun 9, 2016 at 1:12 PM, Oliver Middleton notifications@github.com
|
|
And RangeInclusive is Copy! Oops! |
[breaking-change] due to the removal of Copy which shouldn't have been there in the first place, as per policy set forth in rust-lang#27186.
|
Tests are annoying because rustc won't continue past any error about |
|
Tests added. |
| //~^^^^^^^^ ERROR binary operation | ||
| //~^^^^^^^^^ ERROR binary operation | ||
| //~^^^^^^^^^^ ERROR binary operation | ||
| //~^^^^^^^^^^^ ERROR binary operation |
There was a problem hiding this comment.
Why are these errors duplicated so many times?
There was a problem hiding this comment.
Can you file an issue about the bogus duplicate errors and add a FIXME here linking it?
There was a problem hiding this comment.
Will do.
On Jun 10, 2016 8:27 PM, "Brian Anderson" notifications@github.com wrote:
In src/test/compile-fail/range_traits-1.rs
#34180 (comment):+use std::ops::*;
+
+#[derive(Clone, PartialEq, Eq, PartialOrd, Ord, Hash, Debug)]
+struct AllTheRanges {
- a: Range,
- //~^ ERROR PartialOrd
- //~^^ ERROR PartialOrd
- //~^^^ ERROR Ord
- //~^^^^ ERROR binary operation
- //~^^^^^ ERROR binary operation
- //~^^^^^^ ERROR binary operation
- //~^^^^^^^ ERROR binary operation
- //~^^^^^^^^ ERROR binary operation
- //~^^^^^^^^^ ERROR binary operation
- //~^^^^^^^^^^ ERROR binary operation
- //~^^^^^^^^^^^ ERROR binary operation
Can you file an issue about the bogus duplicate errors and add a FIXME
here linking it?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang/rust/pull/34180/files/53618c36292955b0c79e9ebc02df879015813851#r66696919,
or mute the thread
https://github.com/notifications/unsubscribe/AAC3n2zMYixNPrAmRjPg75o2A7BBa3b9ks5qKgEIgaJpZM4IyD3K
.
|
@brson done. |
|
@bors r+ |
|
📌 Commit df924ca has been approved by |
derive Hash (and not Copy) for ranges Fixes #34170. Also, `RangeInclusive` was `Copy` by mistake -- fix that, which is a [breaking-change] to that unstable type.
Fixes #34170.
Also,
RangeInclusivewasCopyby mistake -- fix that, which is a [breaking-change] to that unstable type.