-
Notifications
You must be signed in to change notification settings - Fork 13.4k
extended information for slice pattern errors (E0527 through E0529) #34319
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
extended information for slice pattern errors (E0527 through E0529) #34319
Conversation
Example of erroneous code: | ||
|
||
```compile_fail | ||
#![feature(slice_patterns)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code throws E0308 on nightly as it seems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it does.
Have you tested your code on nightly? |
That's strange! What specific nightly are you on? I composed these against 5c2a5d4 2016-06-11, and it looks like they still behave the same against bb4a79b 2016-06-15 (which
|
Also, Travis points out that I made a syntax error (which I suppose is only just punishment for relying on CI instead of building it locally); I'll (force-)push a fix for that later. |
I tried on play.rust-lang.org. So maybe the nightly version isn't up-to-date. Don't really know. I'll retry once you'll update it. |
9b3f857
to
f3fa2ef
Compare
@GuillaumeGomez Force-pushed to fix syntax. The playpen was very out of date, but has been fixed now (rust-lang/rust-playpen#215). |
f3fa2ef
to
9c1c399
Compare
Force-pushed again because the corrected code samples were failing tests due to the lack of the |
|
||
Example of erroneous code: | ||
|
||
```compile_fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add "E0527 flag", like this:
```compile_fail,E0527
About the error code flags, take a look here for more information. |
(added error code flags) |
Everything looks good. Can you make a commit for each error code explanation please? (So 3 commits in total.) |
0b7d3ce
to
06599b7
Compare
@GuillaumeGomez Force-pushed with error code test directives squashed into the individual per-extended-error commits (and rebased on master). I regret the delay. |
```compile_fail,E0527 | ||
#![feature(slice_patterns)] | ||
|
||
fn main() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for main function.
No problem. A few nits to fix and it should be good to go! |
☔ The latest upstream changes (presumably #34365) made this pull request unmergeable. Please resolve the merge conflicts. |
💣 Buildbot returned an error: |
⌛ Testing commit e960021 with merge 505842a... |
💔 Test failed - auto-win-msvc-64-opt-no-mir |
@bors: retry On Tue, Aug 2, 2016 at 12:05 PM, bors notifications@github.com wrote:
|
…rors, r=GuillaumeGomez extended information for slice pattern errors (E0527 through E0529) r? @GuillaumeGomez
…rors, r=GuillaumeGomez extended information for slice pattern errors (E0527 through E0529) r? @GuillaumeGomez
…rors, r=GuillaumeGomez extended information for slice pattern errors (E0527 through E0529) r? @GuillaumeGomez
…rors, r=GuillaumeGomez extended information for slice pattern errors (E0527 through E0529) r? @GuillaumeGomez
…rors, r=GuillaumeGomez extended information for slice pattern errors (E0527 through E0529) r? @GuillaumeGomez
Rollup of 30 pull requests - Successful merges: #34319, #35041, #35042, #35076, #35109, #35137, #35175, #35181, #35182, #35189, #35239, #35264, #35266, #35281, #35285, #35289, #35291, #35294, #35296, #35297, #35298, #35299, #35318, #35319, #35324, #35326, #35328, #35333, #35359, #35362 - Failed merges:
r? @GuillaumeGomez