-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add doc example for std::process::ExitStatus::success
.
#34794
Conversation
/// ```rust,no_run | ||
/// use std::process::Command; | ||
/// | ||
/// let status = Command::new("/bin/mkdir") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this perhaps be just "mkdir"? Surely we can assume that it is in the path, and it would avoid platform specific paths. Then again, there isn't actually a mkdir
program on Windows, just a command in shells like cmd or powershell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this perhaps be just "mkdir"? Surely we can assume that it is in the path, and it would avoid platform specific paths.
Updated to just be mkdir
.
Then again, there isn't actually a mkdir program on Windows, just a command in shells like cmd or powershell.
If you have a more cross platform suggestion for this example, let me know.
87d3ce4
to
27e44ed
Compare
I wonder if we should put a note or something for the command. |
For what it's worth, all the |
Right, I guess it's enough. Thanks! @bors: r+ rollup |
📌 Commit 27e44ed has been approved by |
…laumeGomez Add doc example for `std::process::ExitStatus::success`. None
No description provided.