Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add debug for hash_map::{Entry, VacantEntry, OccupiedEntry} #34937

Merged
merged 1 commit into from
Jul 21, 2016

Conversation

GuillaumeGomez
Copy link
Member

@@ -1351,13 +1351,37 @@ pub enum Entry<'a, K: 'a, V: 'a> {
),
}

#[stable(feature= "debug_hash_map", since = "1.12.0")]
impl<'a, K: 'a + Debug + Ord, V: 'a + Debug> Debug for Entry<'a, K, V> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These bounds shouldn't mention Ord.

@GuillaumeGomez
Copy link
Member Author

Updated.

@apasel422
Copy link
Contributor

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 20, 2016

📌 Commit ce442b4 has been approved by apasel422

@alexcrichton
Copy link
Member

@bors: rollup

@apasel422 apasel422 added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 21, 2016
@bors
Copy link
Contributor

bors commented Jul 21, 2016

⌛ Testing commit ce442b4 with merge 5ac9519...

@bors
Copy link
Contributor

bors commented Jul 21, 2016

💔 Test failed - auto-linux-64-cargotest

@alexcrichton
Copy link
Member

@bors: retry

On Wed, Jul 20, 2016 at 6:39 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-cargotest
https://buildbot.rust-lang.org/builders/auto-linux-64-cargotest/builds/1206


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#34937 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95NFVCWAUP2YmDTCl8SBPGVlAKcoZks5qXs3FgaJpZM4JQwRF
.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 21, 2016
…, r=apasel422

Add debug for hash_map::{Entry, VacantEntry, OccupiedEntry}

r? @alexcrichton
@bors bors merged commit ce442b4 into rust-lang:master Jul 21, 2016
@GuillaumeGomez GuillaumeGomez deleted the hash_map_entry_debug branch July 21, 2016 17:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants