resolve: Exclude inaccessible names from single imports #35063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a minor, backwards compatible change that I think would be nice to land outside the Apart from diagnostics, the only observable effect of this PR is to allow, for example: mod foo {
pub fn bar() {}
mod bar {}
}
fn main() {
use foo::bar; // Before this PR, the inaccessible module `foo::bar` was imported,
mod bar {} // so this was a duplicate error.
} |
…ll namespaces, avoid importing the name in the inaccessible namespaces. Currently, the inaccessible namespaces are imported but cause a privacy error when used.
jseyfried
force-pushed
the
avoid_importing_inaccessible_names
branch
from
66bd04d to
8205691
Compare
|
@bors: r+ |
|
📌 Commit 8205691 has been approved by |
|
@bors: rollup assuming this isn't very platform-specific and green travis means it's good to go whenever |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jul 30, 2016
…ble_names, r=nrc resolve: Exclude inaccessible names from single imports If a single import resolves to an inaccessible name in some but not all namespaces, avoid importing the name in the inaccessible namespaces. Currently, the inaccessible namespaces are imported but cause a privacy error when used. r? @nrc
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 30, 2016
…ble_names, r=nrc resolve: Exclude inaccessible names from single imports If a single import resolves to an inaccessible name in some but not all namespaces, avoid importing the name in the inaccessible namespaces. Currently, the inaccessible namespaces are imported but cause a privacy error when used. r? @nrc
bors
added a commit
that referenced
this pull request
Jul 30, 2016
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a single import resolves to an inaccessible name in some but not all namespaces, avoid importing the name in the inaccessible namespaces (per rust-lang/rfcs#1560, cc #35120).
Currently, the inaccessible namespaces are imported but cause a privacy error when used.
r? @nrc