Skip to content

rustc_trans: don't lose the cross-crate DefId, MIR trans needs it. #35197

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 3, 2016

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Aug 2, 2016

We might have been missing out on some issues because MIR trans was never being used cross-crate.

cc @rust-lang/compiler

@rust-highfive
Copy link
Contributor

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb eddyb force-pushed the mir-cross-crate branch from a9409f0 to a419520 Compare August 2, 2016 21:56
@nikomatsakis
Copy link
Contributor

r=me -- for the record, the idea is that if we use the inlined instance, we think the function is local, and then we don't find an entry in the mir-map, so using the original def-id solves that

@eddyb eddyb force-pushed the mir-cross-crate branch from a419520 to ee977e7 Compare August 2, 2016 22:25
@eddyb
Copy link
Member Author

eddyb commented Aug 2, 2016

@bors r=nikomatsakis p=1 (so we don't have a nightly that's not always using MIR trans)

@bors
Copy link
Collaborator

bors commented Aug 2, 2016

📌 Commit ee977e7 has been approved by nikomatsakis

bors added a commit that referenced this pull request Aug 2, 2016
rustc_trans: don't lose the cross-crate DefId, MIR trans needs it.

We might have been missing out on some issues because MIR trans was never being used cross-crate.

cc @rust-lang/compiler
@bors
Copy link
Collaborator

bors commented Aug 2, 2016

⌛ Testing commit ee977e7 with merge 379bfd0...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants