Skip to content

Correct span for pub_restricted field #35491

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 15, 2016

Conversation

sanxiyn
Copy link
Member

@sanxiyn sanxiyn commented Aug 8, 2016

Fix #35435.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@@ -18,6 +20,11 @@ struct Foo {
//~^ error: field `bar` is already declared [E0124]
bar: u8,

pub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest you use a ui test? That way you can actually directly record the highlight that is expected, giving more precision.

@sanxiyn sanxiyn force-pushed the pub-restricted-span branch from a6b40be to f76a737 Compare August 12, 2016 12:09
@sanxiyn
Copy link
Member Author

sanxiyn commented Aug 12, 2016

Changed test to ui test.

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 12, 2016

📌 Commit f76a737 has been approved by nikomatsakis

Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 13, 2016
…matsakis

Correct span for pub_restricted field

Fix rust-lang#35435.
Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 13, 2016
…matsakis

Correct span for pub_restricted field

Fix rust-lang#35435.
@eddyb
Copy link
Member

eddyb commented Aug 14, 2016

@bors rollup

eddyb added a commit to eddyb/rust that referenced this pull request Aug 14, 2016
…matsakis

Correct span for pub_restricted field

Fix rust-lang#35435.
eddyb added a commit to eddyb/rust that referenced this pull request Aug 14, 2016
…matsakis

Correct span for pub_restricted field

Fix rust-lang#35435.
bors added a commit that referenced this pull request Aug 14, 2016
@bors bors merged commit f76a737 into rust-lang:master Aug 15, 2016
@sanxiyn sanxiyn deleted the pub-restricted-span branch August 15, 2016 02:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants