Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Center content of the generated docs #35682

Closed

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez
Copy link
Member Author

Screenshot is here.

@steveklabnik
Copy link
Member

What's the motivation for this change?

@GuillaumeGomez
Copy link
Member Author

Another little improvement to documentation. Too much unused spaces.

@nagisa
Copy link
Member

nagisa commented Aug 15, 2016

Too much unused spaces.

Amount of whitespace does not change, and with this change the mouse travel distance from sidebar/logo to the content and back increases significantly.

@GuillaumeGomez
Copy link
Member Author

@nagisa: It doesn't but it's better used. Also, I don't see the problem with the mouse travel distance.

@strega-nil
Copy link
Contributor

I like the original better. 👎 from me

@steveklabnik
Copy link
Member

Putting this on the meeting agenda.

@GuillaumeGomez
Copy link
Member Author

Thanks @steveklabnik!

@nagisa
Copy link
Member

nagisa commented Aug 15, 2016

Also, I don't see the problem with the mouse travel distance.

Have you used anything other than a mouse to control the pointer? A pointing stick or a trackball? With these (and really, with any device), the less pointer has to move, the better.

@GuillaumeGomez
Copy link
Member Author

I use almost only my keyboard.

@killercup
Copy link
Member

I like the original better as well.

If you wanted to improve readability, you could try setting max-width: 42em for prose text (but don't change anything else like code blocks or tables).

@bors
Copy link
Collaborator

bors commented Aug 17, 2016

☔ The latest upstream changes (presumably #35236) made this pull request unmergeable. Please resolve the merge conflicts.

@peschkaj
Copy link

I prefer the original. The motivation doesn't line up with the implementation. If we're going to make a change, we should align it with a clear goal (e.g. "change markup to improve SEO" or "Add additional accessibility markup" or "Improve readability by setting width to 42em")

@steveklabnik
Copy link
Member

Seems like most people are 👎 , so closing. Thanks anyway @GuillaumeGomez ❤️

@GuillaumeGomez GuillaumeGomez deleted the rustdoc-content branch August 17, 2016 20:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants