replace BitAnd example with something more evocative of bitwise AND
#35809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| /// .iter() | ||
| /// .zip(rhs.value.iter()) | ||
| /// .map(|(x, y)| *x && *y) | ||
| /// .collect(), |
There was a problem hiding this comment.
what happens if you run this code (not inside of ///) through rustfmt?
There was a problem hiding this comment.
I did (see modeline).
But caveat: I first indented iter(), and then invoked rustfmt. In a moment I'll throw up another version that rustfmt accepts.
There was a problem hiding this comment.
I'm surprised rustfmt accepts this since it goes over the column limit.
reformat method chain according to ubsan Rustic Style Guide https://ubsan.github.io/style/
matthew-piziak
force-pushed
the
bitwise-and-example
branch
from
a36a9dc to
9f88f8a
Compare
|
@bors: r+ rollup |
|
📌 Commit 9f88f8a has been approved by |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 22, 2016
… r=GuillaumeGomez replace `BitAnd` example with something more evocative of bitwise AND
matthew-piziak
added a commit
to matthew-piziak/rust
that referenced
this pull request
Aug 30, 2016
These are exactly equivalent to PR rust-lang#35809, with one caveat: I do not believe there is a non-bitwise binary "xor" operator in Rust, so here it's expressed as (a || b) && !(a && b). r? @GuillaumeGomez improved documentation a la PR rust-lang#35993
matthew-piziak
added a commit
to matthew-piziak/rust
that referenced
this pull request
Aug 30, 2016
This is the augmented-assignment version of PR rust-lang#35809. r? @GuillaumeGomez improved documentation a la PR rust-lang#35993
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 30, 2016
… r=GuillaumeGomez add evocative examples for `BitOr` and `BitXor` These are exactly equivalent to PR rust-lang#35809, with one caveat: I do not believe there is a non-bitwise binary XOR operator in Rust, so here it's expressed as `(a || b) && !(a && b)`. Alternative decompositions are `(a && !b) || (!a && b)` and `(a || b) && (!a || !b)`. Let me know if you think one of those would be clearer. r? @GuillaumeGomez
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 31, 2016
… r=GuillaumeGomez add evocative examples for `BitOr` and `BitXor` These are exactly equivalent to PR rust-lang#35809, with one caveat: I do not believe there is a non-bitwise binary XOR operator in Rust, so here it's expressed as `(a || b) && !(a && b)`. Alternative decompositions are `(a && !b) || (!a && b)` and `(a || b) && (!a || !b)`. Let me know if you think one of those would be clearer. r? @GuillaumeGomez
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 31, 2016
… r=GuillaumeGomez add evocative examples for `BitOr` and `BitXor` These are exactly equivalent to PR rust-lang#35809, with one caveat: I do not believe there is a non-bitwise binary XOR operator in Rust, so here it's expressed as `(a || b) && !(a && b)`. Alternative decompositions are `(a && !b) || (!a && b)` and `(a || b) && (!a || !b)`. Let me know if you think one of those would be clearer. r? @GuillaumeGomez
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 31, 2016
…, r=GuillaumeGomez replace `BitAndAssign` example with something more evocative This is the augmented-assignment version of PR rust-lang#35809. r? @GuillaumeGomez
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.