Skip to content

Fix run-pass/signal-exit-status to not trigger UB by writing to NULL. #36129

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 1, 2016

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Aug 30, 2016

run-pass/signal-exit-status has had UB (NULL dereference) since it was introduced in #10109.
Fixes the test failure found by @camlorn while running under Windows Subsystem for Linux.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Aug 30, 2016

📌 Commit 8341f64 has been approved by alexcrichton

@sophiajt
Copy link
Contributor

@bors rollup

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 31, 2016
…chton

Fix run-pass/signal-exit-status to not trigger UB by writing to NULL.

`run-pass/signal-exit-status` has had UB (NULL dereference) since it was introduced in rust-lang#10109.
Fixes the test failure found by @camlorn while running under Windows Subsystem for Linux.
bors added a commit that referenced this pull request Sep 1, 2016
@bors bors merged commit 8341f64 into rust-lang:master Sep 1, 2016
@eddyb eddyb deleted the signal-exit-status branch September 1, 2016 04:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants