-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Avoid instaiblity errors in code generated by syntax_ext::deriving::call_intrinsic()
#36316
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Avoid instaiblity errors in code generated by syntax_ext::deriving::call_intrinsic()
#36316
Conversation
callee: codemap::NameAndSpan { | ||
format: codemap::MacroAttribute(intern(&format!("derive({})", tname))), | ||
span: Some(titem.span), | ||
allow_internal_unstable: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about adding this block of code to call_intrinsic
instead? It's about the same amount of work and wouldn't hide unstable feature usage like the previous implementation did.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, done.
173b47d
to
8eeb57c
Compare
syntax_ext::deriving::call_intrinsic()
You could probably now replace |
ad75287
to
f5f11b3
Compare
f5f11b3
to
d6ea10e
Compare
@bors r=eddyb |
📌 Commit d6ea10e has been approved by |
…ddyb Avoid instaiblity errors in code generated by `syntax_ext::deriving::call_intrinsic()` r? @eddyb
cc @alexcrichton. |
Gah, sorry about the regression! It's not clear to me here what actually regressed, but the solution looks fine. |
@alexcrichton no worries. |
Ah I see, that'd explain the lack of regressions in the main repo! |
#35957 made old-style attribute syntax extensions no longer allow internal instability.
r? @eddyb