Skip to content

Set run button transparent instead of invisible #36334

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 14, 2016

Conversation

GuillaumeGomez
Copy link
Member

r? @steveklabnik

And of course a screenshot:

screenshot from 2016-09-08 01-15-45

@steveklabnik
Copy link
Member

I am interested in giving this a try; I'm sure after it lands in a nightly, people will have opinions, and if it's hated, it's easy enough to revert.

To add some context for everyone else: after talking with a lot of newer Rust people, some of them didn't even notice that this button existed, so this is an attempt to make it more visible without being overwhelming.

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 13, 2016

📌 Commit a2faf54 has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Sep 14, 2016

⌛ Testing commit a2faf54 with merge f1a090b...

@bors
Copy link
Collaborator

bors commented Sep 14, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Sep 13, 2016 at 8:25 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/2496


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#36334 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95DWa3vb--I-NcjUy1yR4sUmI4bdCks5qp2k6gaJpZM4J3dIH
.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 14, 2016
Set run button transparent instead of invisible

r? @steveklabnik

And of course a screenshot:

![screenshot from 2016-09-08 01-15-45](https://cloud.githubusercontent.com/assets/3050060/18331849/31fe1f8c-7562-11e6-9ae9-1dab44089ec6.png)
bors added a commit that referenced this pull request Sep 14, 2016
Rollup of 5 pull requests

- Successful merges: #36334, #36335, #36363, #36374, #36467
- Failed merges:
@bors bors merged commit a2faf54 into rust-lang:master Sep 14, 2016
@GuillaumeGomez GuillaumeGomez deleted the run_but branch September 14, 2016 22:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants