Skip to content

Add missing Eq implementations #36423

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2016
Merged

Add missing Eq implementations #36423

merged 1 commit into from
Sep 22, 2016

Conversation

GuillaumeGomez
Copy link
Member

Part of #36301.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez
Copy link
Member Author

r? @pnkfelix
cc @alexcrichton

@rust-highfive rust-highfive assigned pnkfelix and unassigned brson Sep 14, 2016
@brson
Copy link
Contributor

brson commented Sep 15, 2016

The things here that are not part of a public interface don't need Eq. Just creates more work for the compiler. Looks like fmt::num, dec2flt::FloatErrorKind, flt2dec, IntErrorKind, liblog (though this should be fixed upstream), SafeHash, path::State, pipe::State, are in that category.

@GuillaumeGomez
Copy link
Member Author

I'll remove thos Eq impl then.

@GuillaumeGomez
Copy link
Member Author

Updated.

@pnkfelix
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 22, 2016

📌 Commit b4c739d has been approved by pnkfelix

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 22, 2016
Rollup merge of rust-lang#36423 - GuillaumeGomez:eq_impl, r=pnkfelix
b60fc5d 
Add missing Eq implementations

Part of rust-lang#36301.
@sophiajt sophiajt mentioned this pull request Sep 22, 2016
Merged
bors added a commit that referenced this pull request Sep 22, 2016
@bors
Auto merge of #36651 - jonathandturner:rollup, r=jonathandturner
4c04e36 
Rollup of 7 pull requests

- Successful merges: #36330, #36423, #36539, #36571, #36589, #36600, #36632
- Failed merges:
@bors bors merged commit b4c739d into rust-lang:master Sep 22, 2016
@GuillaumeGomez GuillaumeGomez deleted the eq_impl branch September 23, 2016 10:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @rust-highfive @brson @pnkfelix @bors