-
Notifications
You must be signed in to change notification settings - Fork 13.4k
rustdoc css: Put where
in trait listings on a new line
#36676
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
This is about the gray area at the top of a trait's documentation page, that lists all methods and their signatures. A big trait page like Iterator is very crowded without this tweak.
(rust_highfive has picked a reviewer for you, use r? to override) |
Can you show screenshots please? |
before after images for a trait that doesn't really need this, i.e small and simple trait like Read: http://imgur.com/a/4K5Z3 Itertools docs use this css tweak, and it would be unreadable without it: https://bluss.github.io/rust-itertools/doc/itertools/trait.Itertools.html |
I like it a lot. @rust-lang/docs @rust-lang/tools ? |
Bigger picture, do we even need the gray |
In the long term a better solution might be #36654 applied to all code-like snippets in rustdoc. (Sadly, the |
What if instead of |
That would be a problem with the closing bracket on the same line. |
rustdoc uses that comment style too now
|
Oh damn! This change is absolutely awesome! I really like it! Big 👍 for me! |
👍 This is great. |
I do wonder whether we need the |
Given that virtually everyone is 👍 , let's I agree that messing with the @bors: r+ rollup |
📌 Commit e82d13e has been approved by |
…bnik rustdoc css: Put `where` in trait listings on a new line This is about the gray area at the top of a trait's documentation page, that lists all methods and their signatures. A big trait page like Iterator is very crowded without this tweak.
…bnik rustdoc css: Put `where` in trait listings on a new line This is about the gray area at the top of a trait's documentation page, that lists all methods and their signatures. A big trait page like Iterator is very crowded without this tweak.
This is about the gray area at the top of a trait's documentation page,
that lists all methods and their signatures. A big trait page like
Iterator is very crowded without this tweak.