Skip to content

Run rustfmt on librustc_typeck/check/ folder #36737

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 12, 2016
Merged

Run rustfmt on librustc_typeck/check/ folder #36737

merged 1 commit into from
Oct 12, 2016

Conversation

srinivasreddy
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

/// necessarily available immediately). These routines unwind the
/// promises. It is expected that we will have already reported any
/// errors that may be encountered, so if the promises store an error,
/// a dummy result is returned.
Copy link
Contributor

@Aatch Aatch Sep 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't correct. It isn't supposed to be a doc comment.

_ => bug!()
}))
fcx.type_error_struct(self.span,
|actual| {
Copy link
Contributor

@jseyfried jseyfried Sep 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is misaligned -- rustfmt bug?

@bors
Copy link
Collaborator

bors commented Sep 26, 2016

☔ The latest upstream changes (presumably #36652) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Sep 29, 2016

☔ The latest upstream changes (presumably #36805) made this pull request unmergeable. Please resolve the merge conflicts.

@srinivasreddy
Copy link
Contributor Author

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned Aatch Oct 7, 2016
@nrc
Copy link
Member

nrc commented Oct 12, 2016

@bors: r+

@bors
Copy link
Collaborator

bors commented Oct 12, 2016

📌 Commit 4ef3f59 has been approved by nrc

a: Ty<'tcx>,
b: Ty<'tcx>)
-> CoerceResult<'tcx>
// FIXME(eddyb) use copyable iterators when that becomes ergonomic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this FIXME removed on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops. rustfmt removed it.

@bors
Copy link
Collaborator

bors commented Oct 12, 2016

⌛ Testing commit 4ef3f59 with merge acb50e3...

bors added a commit that referenced this pull request Oct 12, 2016
Run rustfmt on librustc_typeck/check/ folder
@srinivasreddy
Copy link
Contributor Author

srinivasreddy commented Oct 12, 2016

@alexcrichton Can you please stop this merge? I got to keep the FIXME comment

@@ -223,9 +220,8 @@ impl<'f, 'gcx, 'tcx> Coerce<'f, 'gcx, 'tcx> {
r_b: &'tcx ty::Region,
mt_b: TypeAndMut<'tcx>)
-> CoerceResult<'tcx>
// FIXME(eddyb) use copyable iterators when that becomes ergonomic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another one

@@ -662,9 +654,9 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {
new: &'b hir::Expr,
new_ty: Ty<'tcx>)
-> RelateResult<'tcx, Ty<'tcx>>
// FIXME(eddyb) use copyable iterators when that becomes ergonomic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants