Avoid re-export errors in the generated test harness #36787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseyfried
commented
Sep 27, 2016
| // must be re-exported with extra visibility for an error to occur. | ||
| (Ok(value_binding), Ok(type_binding)) if self.new_import_semantics => { | ||
| // All namespaces must be re-exported with extra visibility for an error to occur. | ||
| (Ok(value_binding), Ok(type_binding)) => { |
There was a problem hiding this comment.
This expedites the stabilization of a small, backwards compatible part of RFC 1560 to fix the first issue I described in #36768 (comment).
jseyfried
force-pushed
the
fix_test_harness_reexport_errors
branch
from
28e2b24 to
e5c2f70
Compare
jseyfried
force-pushed
the
fix_test_harness_reexport_errors
branch
from
e5c2f70 to
e89d9af
Compare
jseyfried
force-pushed
the
fix_test_harness_reexport_errors
branch
from
e89d9af to
28393be
Compare
|
@bors: r+ |
|
📌 Commit 28393be has been approved by |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 29, 2016
…_errors, r=nrc Avoid re-export errors in the generated test harness Fixes rust-lang#36768. r? @nrc
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36768.
r? @nrc