#36680 add warning when compliation cache fails to hard link #36821
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
I just saw this now. Sorry for the delay. I'll give you feedback ASAP |
| if !allows_links { | ||
| tcx.sess.warn(&format!("Hard linking files in the incremental compilation | ||
| cache failed. Copying files instead. Consider moving the cache directory to a | ||
| file system which supports hard linking in session dir `{}`" |
There was a problem hiding this comment.
If you have a string that spans multiple lines, you can place a \ at the end of the line. That will (iirc) cause the parser to ignore the leading whitespace in the next line:
// This...
let s = "123
456"
// ... is equivalent to this:
let s = "123\n 456"
// while this:
let s = "123\
456"
// is equivalent to this:
let s = "123456"There was a problem hiding this comment.
The above call would then become the following:
tcx.sess.warn(&format!("Hard linking files in the incremental \
compilation cache failed. Copying files \
instead. Consider moving the cache \
directory to a file system which supports \
hard linking in session dir `{}`"| tcx.sess.warn(&format!("Hard linking files in the incremental compilation | ||
| cache failed. Copying files instead. Consider moving the cache directory to a | ||
| file system which supports hard linking in session dir `{}`" | ||
| , session_dir.display()) |
There was a problem hiding this comment.
It would be more idiomatic to place the comma at the end of previous line.
|
Thanks, pushed some fixes. |
|
@bors r+ Thanks for the PR! |
|
📌 Commit 7cf90d0 has been approved by |
|
⌛ Testing commit 7cf90d0 with merge 9c31d76... |
#36821 I am just starting to learn rust. Feedback would be appreciated.
|
🎉 |
|
Some warnings are better, but it still seems weird, I tried rust today, rustup installation and incremental compilation have encountered this problem, why the compiler is strongly dependent on specific file system feature, there are no relevant prompts before compiler installation, which is very strange. |
#36821
I am just starting to learn rust. Feedback would be appreciated.