-
Notifications
You must be signed in to change notification settings - Fork 13.4k
rustc: Rename rustc_macro to proc_macro #36945
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
r? @nrc This is a [breaking-change] from the current implementation, just blindly renaming everything. I'm curious what you think, though, about this strategy. Do you think it's worth implementing the infrastructure to ensure a smooth transition? It unfortunately wouldn't be easy but it also wouldn't be impossible. Also one point I forgot to mention was that the existing |
I think this is fine without infrastructure to ensure a smooth transition. We'll just fix everything when the nightly comes out, same as usual. |
db2f808
to
e2f9571
Compare
Yeah I'm pretty sure this breaks diesel, serde, and maybe 1-2 other crates. We'll be fine. Just |
[package] | ||
authors = ["The Rust Project Developers"] | ||
name = "proc_macro_plugin" | ||
version = "0.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way better than 1.0
e2f9571
to
903338b
Compare
@bors: r+ |
📌 Commit 903338b has been approved by |
Travis failed:
|
@bors: r- |
903338b
to
d4a29c9
Compare
@bors: r=nrc |
📌 Commit d4a29c9 has been approved by |
⌛ Testing commit d4a29c9 with merge 8aef157... |
@bors: retry force clean
|
⌛ Testing commit d4a29c9 with merge 81e34f8... |
💔 Test failed - auto-win-msvc-64-cargotest |
@bors: retry |
@bors: r- That's legit I think, gotta update Cargo |
We need to ignore them to land rust-lang/rust#36945 and after that we'll shortly re-enable them.
Ignore rustc-macro tests for now We need to ignore them to land rust-lang/rust#36945 and after that we'll shortly re-enable them.
This commit blanket renames the `rustc_macro` infrastructure to `proc_macro`, which reflects the general consensus of rust-lang#35900. A follow up PR to Cargo will be required to purge the `rustc-macro` name as well.
d4a29c9
to
2148bdf
Compare
@bors: r=nrc |
📌 Commit 2148bdf has been approved by |
rustc: Rename rustc_macro to proc_macro This commit blanket renames the `rustc_macro` infrastructure to `proc_macro`, which reflects the general consensus of #35900. A follow up PR to Cargo will be required to purge the `rustc-macro` name as well.
This commit blanket renames the
rustc_macro
infrastructure toproc_macro
,which reflects the general consensus of #35900. A follow up PR to Cargo will be
required to purge the
rustc-macro
name as well.