Skip to content

llvm: Update LLVM to include fix for pathologic case in its LiveDebugValues pass. #37030

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2016
Merged

llvm: Update LLVM to include fix for pathologic case in its LiveDebugValues pass. #37030

merged 3 commits into from
Oct 10, 2016

Conversation

michaelwoerister
Copy link
Member

@michaelwoerister
Copy link
Member Author

Oh, wait, I remembered I need to update something in order not to break the build bots, right? Give me a sec...

@alexcrichton
Copy link
Member

Ah yeah we'll want to modify src/rustllvm/llvm-auto-clean-trigger

@alexcrichton
Copy link
Member

r=me though

@alexcrichton alexcrichton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 7, 2016
@michaelwoerister
Copy link
Member Author

@bors r=alexcrichton

@bors
Copy link
Collaborator

bors commented Oct 7, 2016

📌 Commit 7fcc124 has been approved by alexcrichton

@alexcrichton
Copy link
Member

@bors: p=1

@bors
Copy link
Collaborator

bors commented Oct 7, 2016

⌛ Testing commit 7fcc124 with merge f6409e0...

@bors
Copy link
Collaborator

bors commented Oct 8, 2016

💔 Test failed - auto-linux-32-opt

@arielb1
Copy link
Contributor

arielb1 commented Oct 8, 2016

Don't you also want to incorporate the fix to #36924 here?

@michaelwoerister
Copy link
Member Author

@arielb1 Yes, that seems like a good idea. I'll take care of it.

@michaelwoerister
Copy link
Member Author

I'm currently running make check locally on a branch also containing the SimplifyCFG fix. If that passes, I'll make another PR against the LLVM repo and update this one.

Btw, I have no clue what that test failure above is about. It seems unrelated to changes in LLVM debuginfo generation.

@michaelwoerister
Copy link
Member Author

@bors r=alexcrichton

@alexcrichton I'm assuming, since you merged @arielb1's PR to the LLVM repo, that you are in favor of including that patch with this update...

@bors
Copy link
Collaborator

bors commented Oct 10, 2016

📌 Commit 7d03bad has been approved by alexcrichton

@michaelwoerister
Copy link
Member Author

@bors p=1

@alexcrichton
Copy link
Member

👍

@alexcrichton
Copy link
Member

@bors: retry force clean

@bors
Copy link
Collaborator

bors commented Oct 10, 2016

⌛ Testing commit 7d03bad with merge a3bc191...

bors added a commit that referenced this pull request Oct 10, 2016
@bors
Auto merge of #37030 - michaelwoerister:live-debug-values-fix, r=alex…
a3bc191 
…crichton

llvm: Update LLVM to include fix for pathologic case in its LiveDebugValues pass.

See #36926.
r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Oct 10, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: alexcrichton
Pushing a3bc191 to master...

@bors bors merged commit 7d03bad into rust-lang:master Oct 10, 2016
@nikomatsakis
Copy link
Contributor

Accepting for beta because terrible regression. However, this is bumping LLVM, incorporating the following commits, all of which seem relatively targeted to me.

cc @rust-lang/compiler

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 11, 2016
@brson brson mentioned this pull request Oct 14, 2016
Closed
This was referenced Oct 14, 2016
Merged
Merged
@michaelwoerister michaelwoerister removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 14, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michaelwoerister @alexcrichton @bors @arielb1 @nikomatsakis