Clean up some FIXMEs. #37104
Merged
Clean up some FIXMEs. #37104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
pnkfelix
reviewed
Oct 20, 2016
| // FIXME(#20649) -- why are we using the `self_ty` as the element type...? | ||
| let self_ty = method_ty.fn_sig().input(0); | ||
| (self.tcx().no_late_bound_regions(&self_ty).unwrap(), | ||
| (ref_ty.builtin_deref(false, ty::NoPreference).unwrap().ty, |
There was a problem hiding this comment.
does this represent a change in analysis behavior?
There was a problem hiding this comment.
Not that I could see and passed make check. Also @nikomatsakis mentioned on the issue that he didn't expect any effect.
|
ping r? @pnkfelix |
|
☔ The latest upstream changes (presumably #37670) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
added
the
T-compiler
|
r=me w/ rebase. |
|
@bors r=eddyb |
|
@bors r+ |
|
📌 Commit c2f1e5d has been approved by |
bors
added a commit
that referenced
this pull request
Nov 11, 2016
Clean up some FIXMEs. Remove some assorted FIXMEs in the codebase.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some assorted FIXMEs in the codebase.