normalize tuple pair types in trans #37110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 7badc32 has been approved by |
eddyb
added
the
beta-nominated
|
Why are we passing a non-normalized tuple around anyway? |
|
Oh for some reason I thought this had soemthing to do with tuple structs, oops. Yeah that is interesting, makes this only a bandaid. |
|
I have a better fix. |
|
@bors r- |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 12, 2016
normalize tuple pair types in trans Fixes rust-lang#37109. Note that rust-lang#37109 is a regression from stable to stable, beta and nightly.
bors
added a commit
that referenced
this pull request
Oct 12, 2016
|
It's not clear that this should be backported to beta, or that #37129 should instead. |
brson
removed
the
beta-nominated
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37109.
Note that #37109 is a regression from stable to stable, beta and nightly.