Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix $crate-related regressions #37361

Merged
merged 3 commits into from
Oct 26, 2016
Merged

Fix $crate-related regressions #37361

merged 3 commits into from
Oct 26, 2016

Conversation

jseyfried
Copy link
Contributor

Fixes #37345, fixes #37357, fixes #37352, and improves the unused_extern_crates lint.
r? @nrc

@jseyfried jseyfried force-pushed the fix_crate_var_regressions branch from 1cf3220 to 9106d21 Compare October 23, 2016 05:58
This was referenced Oct 23, 2016
Closed
Closed
Closed
@petrochenkov
Copy link
Contributor

FWIW, local use $crate; is very similar to use::super; importing the crate root from #37156.
I'd say both should be legal and import a special unusable name, and use $crate as x;/use::super as x; should be legal and declare name x referring to the root module.

@kvark kvark mentioned this pull request Oct 24, 2016
Closed
@nrc
Copy link
Member

nrc commented Oct 25, 2016

@bors r+

Could you file a tracking issue for use $crate; please?

@bors
Copy link
Collaborator

bors commented Oct 25, 2016

📌 Commit 9106d21 has been approved by nrc

@jseyfried jseyfried mentioned this pull request Oct 25, 2016
Closed
@jseyfried
Copy link
Contributor Author

cc #37390

@bors
Copy link
Collaborator

bors commented Oct 25, 2016

☔ The latest upstream changes (presumably #37292) made this pull request unmergeable. Please resolve the merge conflicts.

@jseyfried jseyfried force-pushed the fix_crate_var_regressions branch from 9106d21 to 0d30325 Compare October 25, 2016 20:41
@jseyfried
Copy link
Contributor Author

@bors r=nrc

@bors
Copy link
Collaborator

bors commented Oct 25, 2016

📌 Commit 0d30325 has been approved by nrc

@jseyfried
Copy link
Contributor Author

@bors p=1 (this is causing a lot of regressions in practice)

@bors
Copy link
Collaborator

bors commented Oct 26, 2016

⌛ Testing commit 0d30325 with merge a7557e7...

bors added a commit that referenced this pull request Oct 26, 2016
@bors
Auto merge of #37361 - jseyfried:fix_crate_var_regressions, r=nrc
a7557e7 
Fix `$crate`-related regressions

Fixes #37345, fixes #37357, fixes #37352, and improves the `unused_extern_crates` lint.
r? @nrc
@bors
Copy link
Collaborator

bors commented Oct 26, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: nrc
Pushing a7557e7 to master...

@bors bors merged commit 0d30325 into rust-lang:master Oct 26, 2016
@jseyfried jseyfried deleted the fix_crate_var_regressions branch October 26, 2016 05:10
@retep998 retep998 mentioned this pull request Oct 27, 2016
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jseyfried @petrochenkov @nrc @bors