rustc_llvm: Require 3.9 for --link-static #37667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently stock Ubuntu 16.04 includes LLVM 3.8 which doesn't have this flag.
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
|
📌 Commit cc2c812 has been approved by |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit cc2c812 has been approved by |
|
Sorry about that :-( Must have mixed up the versions. |
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Nov 10, 2016
…paric rustc_llvm: Require 3.9 for --link-static Apparently stock Ubuntu 16.04 includes LLVM 3.8 which doesn't have this flag.
|
BTW, the mistaken 3.8 condition made it into beta. Might this fix be backported? |
alexcrichton
added
the
beta-nominated
|
Sure! Nominating for beta |
|
Although now that I think about it, I'm not using rustbuild in Fedora yet, so it won't actually affect me anyway. Still, it's a trivial fix. |
|
Ah ok, in that case we tend to prefer backporting wherever possible (as the fix comes in 6 weeks anyway). In that case I'll un-nominate. |
alexcrichton
removed
the
beta-nominated
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently stock Ubuntu 16.04 includes LLVM 3.8 which doesn't have this flag.