Skip to content

Clarify the reference's status. #37836

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

steveklabnik
Copy link
Member

@steveklabnik steveklabnik commented Nov 17, 2016

The former wording only gave part of the picture, we want to be crystal
clear about this.

/cc @petrochenkov, who had concerns about #37820

The former wording only gave part of the picture, we want to be crystal
clear about this.
@rust-highfive
Copy link
Contributor

@steveklabnik: no appropriate reviewer found, use r? to override

@GuillaumeGomez
Copy link
Member

Well, feel better about this but the previous solution was fine by me as well. :-/

@matklad
Copy link
Member

matklad commented Nov 21, 2016

👍 It is indeed very incomplete. I'd probably dropped necessarily word, because is incomplete is more direct and more true :)

Not sure about accuracy and freshness. I bet a thorough review would find at least a handful of false statements :)

It would be a great idea to add a big WIP warning to the reference itself, because the current introduction sounds too assuring: https://doc.rust-lang.org/reference.html#introduction

@GuillaumeGomez
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 21, 2016

📌 Commit c5e6dfc has been approved by GuillaumeGomez

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 23, 2016
…ence-comment, r=GuillaumeGomez

Clarify the reference's status.

The former wording only gave part of the picture, we want to be crystal
clear about this.

/cc @petrochenkov, who had concerns about rust-lang#37820
bors added a commit that referenced this pull request Nov 23, 2016
Rollup of 7 pull requests

- Successful merges: #37442, #37760, #37836, #37851, #37859, #37913, #37925
- Failed merges:
@bors bors merged commit c5e6dfc into rust-lang:master Nov 23, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants