Skip to content

Restore compatibility with LLVM 3.7 and 3.8 #37912

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 21, 2016
Merged

Conversation

sanxiyn
Copy link
Member

@sanxiyn sanxiyn commented Nov 21, 2016

#37831 broke compatibility with LLVM 3.7 and 3.8. While LLVM Attribute API has been there for a long time, LLVM Attribute API C binding, including LLVMAttributeRef type, is new in LLVM 3.9. This patch avoids uses of LLVMAttributeRef.

This should fix Travis build.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb
Copy link
Member

eddyb commented Nov 21, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 21, 2016

📌 Commit c45f3de has been approved by eddyb

@pnkfelix
Copy link
Member

@bors p=2

(just in case a PR with a lower number like mine is r plussed in the interim)

@bors
Copy link
Collaborator

bors commented Nov 21, 2016

⌛ Testing commit c45f3de with merge 80a95e3...

bors added a commit that referenced this pull request Nov 21, 2016
Restore compatibility with LLVM 3.7 and 3.8

This should fix Travis build.
@bors bors merged commit c45f3de into rust-lang:master Nov 21, 2016
@sanxiyn sanxiyn deleted the llvm-compat branch November 22, 2016 03:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants