Allow legacy custom derive authors to disable warnings in downstream crates #38533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrc
approved these changes
Dec 23, 2016
| @@ -115,6 +118,17 @@ impl<'a> Registry<'a> { | |||
| })); | |||
| } | |||
|
|
|||
| #[unstable(feature = "rustc_private", issue = "27812")] | |||
| #[rustc_deprecated(since = "1.15.0", reason = "replaced by macros 1.1 (RFC 1861)")] | |||
| pub fn register_custom_derive(&mut self, name: ast::Name, extension: SyntaxExtension) { | |||
There was a problem hiding this comment.
Could you document here when an author should use this and what its effects are please?
jseyfried
force-pushed
the
legacy_custom_derive_deprecation
branch
from
b0243d6 to
fa3e910
Compare
jseyfried
force-pushed
the
legacy_custom_derive_deprecation
branch
from
fa3e910 to
c12fc66
Compare
|
@bors r=nrc |
|
📌 Commit c12fc66 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 23, 2016
Allow legacy custom derive authors to disable warnings in downstream crates This PR allows legacy custom derive authors to use a pre-deprecated method `registry.register_custom_derive()` instead of `registry.register_syntax_extension()` to avoid downstream deprecation warnings. r? @nrc
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows legacy custom derive authors to use a pre-deprecated method
registry.register_custom_derive()instead ofregistry.register_syntax_extension()to avoid downstream deprecation warnings.r? @nrc