Skip to content

resolve: fix non-termination #38539

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 25, 2016
Merged

resolve: fix non-termination #38539

merged 1 commit into from
Dec 25, 2016

Conversation

jseyfried
Copy link
Contributor

Fixes #34324.
r? @eddyb

jseyfried
jseyfried commented Dec 22, 2016
View reviewed changes
src/test/compile-fail/recursive-reexports.rs
@@ -10,6 +10,8 @@

// aux-build:recursive_reexports.rs

extern crate recursive_reexports;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test used to be broken 😳

@eddyb
Copy link
Member

eddyb commented Dec 22, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 22, 2016

📌 Commit ff54a4e has been approved by eddyb

@eddyb
Copy link
Member

eddyb commented Dec 22, 2016

Does this need a backport?

@jseyfried
Copy link
Contributor Author

Yeah, I think this would be a good idea to backport.

@jseyfried jseyfried added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 22, 2016
@jseyfried jseyfried mentioned this pull request Dec 22, 2016
Closed
@eddyb eddyb added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 22, 2016
@jseyfried
Copy link
Contributor Author

@bors r=eddyb

@bors
Copy link
Collaborator

bors commented Dec 23, 2016

📌 Commit 098c9b6 has been approved by eddyb

@jseyfried
Copy link
Contributor Author

@bors p=1

@bors
Copy link
Collaborator

bors commented Dec 25, 2016

⌛ Testing commit 098c9b6 with merge 20b6c16...

bors added a commit that referenced this pull request Dec 25, 2016
@bors
Auto merge of #38539 - jseyfried:fix_resolve_hang, r=eddyb
20b6c16 
resolve: fix non-termination

Fixes #34324.
r? @eddyb
@bors
Copy link
Collaborator

bors commented Dec 25, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing 20b6c16 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Dec 25, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing 20b6c16 to master...

@bors bors merged commit 098c9b6 into rust-lang:master Dec 25, 2016
@jseyfried jseyfried deleted the fix_resolve_hang branch December 26, 2016 05:51
@jseyfried jseyfried mentioned this pull request Dec 26, 2016
Closed
@nikomatsakis
Copy link
Contributor

Marking as beta-accepted. Small patch, serious regression. cc @rust-lang/compiler

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 30, 2016
@alexcrichton alexcrichton mentioned this pull request Dec 30, 2016
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 30, 2016
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 7, 2018
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jseyfried @eddyb @bors @nikomatsakis @brson