Rollup of 14 pull requests #38594
Merged
Rollup of 14 pull requests #38594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small bug fix to remove an unused type in the magenta process code that causes build failures for magenta's rustc.
The Markdown engine used by the book can cope with a single leading space
on the list marker:
Like this:
* List item
Rather than like this:
* List item
… but it’s not the typical convention employed in the book, and moreover
the Markdown engine used for producing the error index *can’t* cope with
it (its behaviour looks like a bug, as it appears to lose one of the two
line breaks as well, but that’s immaterial here).
So, we shift to a single convention which doesn’t trigger bugs in the
Markdown renderer.
book: replace example I do not understand
…abnik Simplify notes on testing and concurrency The start of the notes on tests running concurrently, added in rust-lang#37766 read a little awkwardly. This PR fixes that and simplifies the wording a bit. r? @steveklabnik
…r=GuillaumeGomez Advertise Vec in LinkedList docs r? @steveklabnik Hi! We already [advise](https://doc.rust-lang.org/std/collections/#use-a-linkedlist-when) to use `Vec` instead of `LinkedList` in the top-level collections documentation. But I think it may be missed by someone who just directly finds `LinkedList`. What do you feel about advertising `Vec` directly in `LinkedList` docs as well?
Don't @import normalize.css. This lets the browser load both files in parallel instead of waiting for `rustdoc.css` to load first.
…, r=steveklabnik rustdoc: properly calculate line length for where clauses Apparently, while I was cleaning up rust-lang#37190, I regressed the formatting for long where clauses, where it wouldn't take the "prefix" length into account when deciding whether to break the line up. This patch fixes that.
…impls, r=nikomatsakis ICH: Add test cases for inherent impls. r? @nikomatsakis
Docs: Explain why/when `.lines()` returns an error Fix rust-lang#37744.
…ewsxcv Add missing examples in some thread functions r? @frewsxcv
…ackler Removes magenta build warning. Small bug fix to remove an unused type in the magenta process code that causes build failures for magenta's rustc. r? @alexcrichton @tedsta @raphlinus
…e, r=nikomatsakis Correct path of incremental artifacts Per rust-lang#38072 (comment) r? @nikomatsakis
Create hyperlink to correct documentation In librustc_trans's readme
…nikomatsakis incr. comp.: Improve InlineAsm hashing and add test case r? @nikomatsakis
…frewsxcv
Fix Markdown list formatting.
The Markdown engine used by the book can cope with a single leading space on the list marker:
Like this:
* List item
Rather than like this:
* List item
… but it’s not the typical convention employed in the book, and moreover the Markdown engine used for producing the error index *can’t* cope with it (its behaviour looks like a bug, as it appears to lose one of the two line breaks as well, but that’s immaterial here).
So, we shift to a single convention which doesn’t trigger bugs in the Markdown renderer.
----
See https://doc.rust-lang.org/error-index.html#E0458 and https://doc.rust-lang.org/error-index.html#E0101 for the bad current rendering in the error index.
…frewsxcv Add JoinHandle missing examples r? @frewsxcv
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit df63b0c has been approved by |
bors
added a commit
that referenced
this pull request
Dec 24, 2016
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.lines()returns an error #38505, Add missing examples in some thread functions #38513, Removes magenta build warning. #38521, Correct path of incremental artifacts #38549, Create hyperlink to correct documentation #38554, incr. comp.: Improve InlineAsm hashing and add test case #38557, Fix Markdown list formatting. #38568, Add JoinHandle missing examples #38572