Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove --crate-type=metadata from beta #38668

Merged
merged 1 commit into from
Dec 29, 2016

Conversation

nrc
Copy link
Member

@nrc nrc commented Dec 29, 2016

Leaves most of the implementation, just ignores the argument itself.

r? @alexcrichton

Leaves most of the implementation, just ignores the argument itself.
@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@nrc
Copy link
Member Author

nrc commented Dec 29, 2016

cc #38666

@alexcrichton
Copy link
Member

@nrc oh one thing I just thought of was also #![crate_type = "metadata"], do we need to update something somewhere to also not accept that? Or is that handled here as well?

@nrc
Copy link
Member Author

nrc commented Dec 29, 2016

@alexcrichton That is handled here too.

@alexcrichton
Copy link
Member

Ok!

@alexcrichton alexcrichton merged commit dd582c0 into rust-lang:beta Dec 29, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants