Fix regression with duplicate `#[macro_export] macro_rules!` #38793

jseyfried · 2017-01-03T02:51:33Z

brson · 2017-01-03T21:49:45Z

nrc

r = me with the comment in the test

nrc · 2017-01-04T05:45:13Z

src/test/run-pass/auxiliary/issue_38715.rs

+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+


Could you add a comment explaining what is being tested please?

jseyfried · 2017-01-04T08:04:11Z

@bors r=nrc

bors · 2017-01-04T08:04:14Z

📌 Commit 927408d has been approved by nrc

nikomatsakis · 2017-01-04T20:15:48Z

Regression. Small patch. Low impact. Accepted for beta. cc @rust-lang/compiler

alexcrichton · 2017-01-04T22:09:33Z

@bors: p=1

(this is approved, we'll want to backport)

bors · 2017-01-04T23:09:00Z

⌛ Testing commit 927408d with merge 485e2a4...

bors · 2017-01-05T00:11:11Z

💔 Test failed - status-travis

alexcrichton · 2017-01-05T01:14:23Z

@bors: retry * osx linker segfaulted

…

On Wed, Jan 4, 2017 at 4:11 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/189017797> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#38793 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95DeLRutVEzo6BE2mPRhn4bBSDjmlks5rPDUhgaJpZM4LZTie> .

bors · 2017-01-05T02:10:46Z

⌛ Testing commit 927408d with merge f7f5950...

bors · 2017-01-05T02:47:34Z

💔 Test failed - status-travis

alexcrichton · 2017-01-05T17:06:59Z

@bors: retry * sccache wedged?

…

On Wed, Jan 4, 2017 at 6:47 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/189053714> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#38793 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95I4CVi6vdAXnT6FSQu0TZIHR6NQDks5rPFnIgaJpZM4LZTie> .

bors · 2017-01-05T17:11:35Z

⌛ Testing commit 927408d with merge c711172...

bors · 2017-01-05T17:16:53Z

💔 Test failed - status-travis

alexcrichton · 2017-01-05T17:18:45Z

@bors: retry * network failure

…

On Thu, Jan 5, 2017 at 9:16 AM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/189252660> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#38793 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95HEKyHO3HIBUGqSj6RSKh4rnLQV0ks5rPSWGgaJpZM4LZTie> .

bors · 2017-01-05T17:24:10Z

⌛ Testing commit 927408d with merge 4b0378d...

bors · 2017-01-05T17:29:15Z

💔 Test failed - status-travis

alexcrichton · 2017-01-05T17:32:17Z

@bors: retry * network failure

…

On Thu, Jan 5, 2017 at 9:29 AM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/189256149> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#38793 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95EIwi0tOjilLM881652hkdklJJNhks5rPShtgaJpZM4LZTie> .

bors · 2017-01-05T18:07:21Z

⌛ Testing commit 927408d with merge 131d5ce...

@nrc

Fix regression with duplicate `#[macro_export] macro_rules!` Fixes #38715. r? @nrc

bors · 2017-01-05T19:56:04Z

💔 Test failed - status-travis

alexcrichton · 2017-01-05T20:32:25Z

@bors: retry * osx linker segfaulted

…

On Thu, Jan 5, 2017 at 11:56 AM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/189268798> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#38793 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95EBB4BPMaFQojIBbv77oTLHiZRTFks5rPUrXgaJpZM4LZTie> .

bors · 2017-01-06T00:05:31Z

⌛ Testing commit 927408d with merge 0fc0e17...

bors · 2017-01-06T00:12:03Z

💔 Test failed - status-travis

alexcrichton · 2017-01-06T00:35:37Z

@bors: retry * network error

…

On Thu, Jan 5, 2017 at 4:12 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/189366514> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#38793 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95KbRZnzENMYcDPydpeBrlhPIoELjks5rPYbVgaJpZM4LZTie> .

bors · 2017-01-06T02:19:16Z

⌛ Testing commit 927408d with merge c4065eb...

bors · 2017-01-06T03:39:36Z

💔 Test failed - status-travis

alexcrichton · 2017-01-06T06:16:22Z

@bors: retry * osx linker segfaulted

…

On Thu, Jan 5, 2017 at 7:39 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/189389301> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#38793 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95PddDCMyu9BnjLu7O-v95pR9OAN9ks5rPbd6gaJpZM4LZTie> .

bors · 2017-01-06T06:41:11Z

⌛ Testing commit 927408d with merge e7907a9...

@nrc

Fix regression with duplicate `#[macro_export] macro_rules!` Fixes #38715. r? @nrc

bors · 2017-01-06T08:46:29Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nrc
Pushing e7907a9 to master...

rust-highfive assigned nrc Jan 3, 2017

jseyfried mentioned this pull request Jan 3, 2017

Regression in test suite of probor-0.2.1 in Rust 1.15 #38715

Closed

jseyfried added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 3, 2017

nrc approved these changes Jan 4, 2017

View reviewed changes

jseyfried force-pushed the fix_macro_export_duplicates branch from 4d43052 to 78afcc9 Compare January 4, 2017 08:02

Fix regression with duplicate #[macro_export] macro_rules!.

927408d

jseyfried force-pushed the fix_macro_export_duplicates branch from 78afcc9 to 927408d Compare January 4, 2017 08:03

nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 4, 2017

bors added a commit that referenced this pull request Jan 5, 2017

Auto merge of #38793 - jseyfried:fix_macro_export_duplicates, r=nrc

131d5ce

Fix regression with duplicate `#[macro_export] macro_rules!` Fixes #38715. r? @nrc

bors added a commit that referenced this pull request Jan 6, 2017

Auto merge of #38793 - jseyfried:fix_macro_export_duplicates, r=nrc

e7907a9

Fix regression with duplicate `#[macro_export] macro_rules!` Fixes #38715. r? @nrc

bors merged commit 927408d into rust-lang:master Jan 6, 2017

nikomatsakis mentioned this pull request Jan 6, 2017

Beta backports #38872

Merged

17 tasks

alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 6, 2017

Fix regression with duplicate #[macro_export] macro_rules! #38793

Fix regression with duplicate #[macro_export] macro_rules! #38793

Uh oh!

Conversation

jseyfried commented Jan 3, 2017

Uh oh!

brson commented Jan 3, 2017

Uh oh!

nrc left a comment

Choose a reason for hiding this comment

Uh oh!

nrc Jan 4, 2017

Choose a reason for hiding this comment

Uh oh!

jseyfried Jan 4, 2017

Choose a reason for hiding this comment

Uh oh!

jseyfried commented Jan 4, 2017

Uh oh!

bors commented Jan 4, 2017

Uh oh!

nikomatsakis commented Jan 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexcrichton commented Jan 4, 2017

Uh oh!

bors commented Jan 4, 2017

Uh oh!

bors commented Jan 5, 2017

Uh oh!

alexcrichton commented Jan 5, 2017 via email

Uh oh!

bors commented Jan 5, 2017

Uh oh!

bors commented Jan 5, 2017

Uh oh!

alexcrichton commented Jan 5, 2017 via email

Uh oh!

bors commented Jan 5, 2017

Uh oh!

bors commented Jan 5, 2017

Uh oh!

alexcrichton commented Jan 5, 2017 via email

Uh oh!

bors commented Jan 5, 2017

Uh oh!

bors commented Jan 5, 2017

Uh oh!

alexcrichton commented Jan 5, 2017 via email

Uh oh!

bors commented Jan 5, 2017

Uh oh!

bors commented Jan 5, 2017

Uh oh!

alexcrichton commented Jan 5, 2017 via email

Uh oh!

bors commented Jan 6, 2017

Uh oh!

bors commented Jan 6, 2017

Uh oh!

alexcrichton commented Jan 6, 2017 via email

Uh oh!

bors commented Jan 6, 2017

Uh oh!

bors commented Jan 6, 2017

Uh oh!

alexcrichton commented Jan 6, 2017 via email

Uh oh!

bors commented Jan 6, 2017

Uh oh!

bors commented Jan 6, 2017

Uh oh!

Uh oh!

Fix regression with duplicate `#[macro_export] macro_rules!` #38793

Fix regression with duplicate `#[macro_export] macro_rules!` #38793

nikomatsakis commented Jan 4, 2017 •

edited

Loading