Skip to content

Expand {Path,OsStr}::{to_str,to_string_lossy} doc examples. #38839

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2017
Merged

Expand {Path,OsStr}::{to_str,to_string_lossy} doc examples. #38839

merged 1 commit into from
Jan 10, 2017

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Jan 5, 2017

No description provided.

ollie27
ollie27 reviewed Jan 5, 2017
View reviewed changes
src/libstd/ffi/os_str.rs
///
/// unsafe {
/// let bytes = b"foo\xc3".to_vec();
/// let string = String::from_utf8_unchecked(bytes);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this Undefined Behaviour?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still UB if it doesn't get represented as a string?

@strega-nil
Copy link
Contributor

Please no :(

@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 5, 2017

Please no :(

In retrospect, I agree. I overlooked that what I am doing is UB.

@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 5, 2017

Let me know if the latest changes look better.

@strega-nil
Copy link
Contributor

Much nicer :)

@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 5, 2017

Squashed.

@GuillaumeGomez
Copy link
Member

Good for me as well. Thanks for the review @ubsan! ;)

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 5, 2017

📌 Commit 4794f95 has been approved by GuillaumeGomez

@frewsxcv frewsxcv mentioned this pull request Jan 9, 2017
Closed
sanxiyn added a commit to sanxiyn/rust that referenced this pull request Jan 10, 2017
@sanxiyn
Rollup merge of rust-lang#38839 - frewsxcv:osstr-to-str, r=GuillaumeG…
20c7dbc 
…omez

Expand {Path,OsStr}::{to_str,to_string_lossy} doc examples.

None
@sanxiyn sanxiyn mentioned this pull request Jan 10, 2017
Merged
bors added a commit that referenced this pull request Jan 10, 2017
@bors
Auto merge of #38958 - sanxiyn:rollup, r=sanxiyn
7bffede 
Rollup of 11 pull requests

- Successful merges: #38606, #38607, #38623, #38664, #38799, #38816, #38836, #38839, #38841, #38849, #38874
- Failed merges: #38845
@bors bors merged commit 4794f95 into rust-lang:master Jan 10, 2017
@frewsxcv frewsxcv deleted the osstr-to-str branch June 19, 2017 14:56
@frewsxcv frewsxcv mentioned this pull request Jun 19, 2017
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ollie27 ollie27 ollie27 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frewsxcv @strega-nil @GuillaumeGomez @bors @ollie27