[Gate Tests] - marking feature tests #39250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
np |
|
@cseale the PR got merged. |
|
☔ The latest upstream changes (presumably #39075) made this pull request unmergeable. Please resolve the merge conflicts. |
est31
approved these changes
Jan 28, 2017
20 tasks
jseyfried
reviewed
Jan 29, 2017
| @@ -166,8 +166,7 @@ pub fn check(path: &Path, bad: &mut bool) { | |||
|
|
|||
| // FIXME get this whitelist empty. | |||
| let whitelist = vec
There was a problem hiding this comment.
Why was "reflect" added here?
There was a problem hiding this comment.
It was removed by #39075, so shouldn't be present.
est31
approved these changes
Jan 29, 2017
est31
reviewed
Jan 29, 2017
| @@ -166,8 +166,7 @@ pub fn check(path: &Path, bad: &mut bool) { | |||
|
|
|||
| // FIXME get this whitelist empty. | |||
| let whitelist = vec
|
@bors delegate=est31 |
|
✌️ @est31 can now approve this pull request |
Removal of the lang feature gate tests whitelist rust-lang#39059 r? @est31
|
@bors r+ |
|
📌 Commit 94e9086 has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of the lang feature gate tests whitelist #39059
r? @est31