-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Conversions between slices and boxes #39438
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Since these impls are instantly stable, we need the full libs team to sign off. Personally, I think that we will continue growing such impls until the end of time. Due to trait coherence, @rfcbot fcp merge |
Whoops, didn't have the libs team assigned first, trying again: @rfcbot fcp merge |
Team member @aturon has proposed to merge this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
Reminder to self for later: also add versions for CStr and OsStr |
@clarcharr the compile failures here seem worrisome, they may want to be fixed! |
@alexcrichton I'll fix those soon; I know what's wrong. Instead of using |
Waiting on tests, but this should work now. I also added an implementation for |
69e4ee6
to
7b71cd1
Compare
@clarcharr perhaps the |
Sounds good to me! I'll split them out and open another PR. |
@malbarbo That's because it's more efficient if the type implements |
@clarcharr You can use |
@malbarbo right now that'll work for |
So apparently this didn't get merged? Did I miss something? |
⌛ Testing commit 550373b with merge 8482c4b... |
@clarcharr The rollup pr failed, so you will have to wait till the next rollup. (Got a pr of mine merged after 6 rollup prs) |
💔 Test failed - status-appveyor |
… On Fri, Feb 10, 2017 at 12:40 AM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.1883>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#39438 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95C5k6K2gP7Th6wU9oi22LPWVIz9Kks5rbCKFgaJpZM4LzdpA>
.
|
Conversions between slices and boxes This allows conversion for `Copy` slices, `str`, and `CStr` into their boxed counterparts. This also adds the method `CString::into_boxed_c_str`. I would like to add similar implementations for `OsStr` as well, but I have not figured out how.
⌛ Testing commit 550373b with merge 16f5492... |
💔 Test failed - status-travis |
dist-mips-linux:
|
… On Fri, Feb 10, 2017 at 11:18 AM, bjorn3 ***@***.***> wrote:
dist-mips-linux:
[...]
[ 83%] Built target LLVMMSP430Info
Scanning dependencies of target LLVMMSP430Desc
[ 83%] Building CXX object lib/Target/MSP430/MCTargetDesc/CMakeFiles/LLVMMSP430Desc.dir/MSP430MCTargetDesc.cpp.o
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#39438 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95D926SXesz_zCfgWxi0pvlElq3ccks5rbLgdgaJpZM4LzdpA>
.
|
⌛ Testing commit 550373b with merge 99b6677... |
💔 Test failed - status-travis |
Conversions between slices and boxes This allows conversion for `Copy` slices, `str`, and `CStr` into their boxed counterparts. This also adds the method `CString::into_boxed_c_str`. I would like to add similar implementations for `OsStr` as well, but I have not figured out how.
☀️ Test successful - status-appveyor, status-travis |
@alexcrichton Sadly, no. I haven't seen the thread sanitizer not catch that data race before. I'll test locally to see if I can repro. |
This allows conversion for
Copy
slices,str
, andCStr
into their boxed counterparts.This also adds the method
CString::into_boxed_c_str
.I would like to add similar implementations for
OsStr
as well, but I have not figured out how.