Skip to content

Uninhabited while-let pattern fix #39526

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Feb 5, 2017

Conversation

canndrew
Copy link
Contributor

@canndrew canndrew commented Feb 4, 2017

This fix makes it so while-let with an unsatisfiable pattern raises a correct warning rather than an incorrect error.

@rust-highfive
Copy link
Contributor

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb
Copy link
Member

eddyb commented Feb 4, 2017

Does this need to be backported? cc @rust-lang/compiler

@arielb1 arielb1 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 4, 2017
@canndrew
Copy link
Contributor Author

canndrew commented Feb 5, 2017

@arielb1 All done.

@arielb1
Copy link
Contributor

arielb1 commented Feb 5, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 5, 2017

📌 Commit 7135d0a has been approved by arielb1

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
… r=arielb1

Uninhabited while-let pattern fix

This fix makes it so while-let with an unsatisfiable pattern raises a correct warning rather than an incorrect error.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
… r=arielb1

Uninhabited while-let pattern fix

This fix makes it so while-let with an unsatisfiable pattern raises a correct warning rather than an incorrect error.
bors added a commit that referenced this pull request Feb 5, 2017
Rollup of 12 pull requests

- Successful merges: #39439, #39472, #39481, #39491, #39501, #39509, #39514, #39519, #39526, #39528, #39530, #39538
- Failed merges:
@bors bors merged commit 7135d0a into rust-lang:master Feb 5, 2017
@canndrew
Copy link
Contributor Author

canndrew commented Feb 9, 2017

@eddyb You mean backported to beta? Probably, yes.

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 9, 2017
@nikomatsakis
Copy link
Contributor

Approved for beta backport: small, isolated change; regression.

cc @rust-lang/compiler

@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 11, 2017
bors added a commit that referenced this pull request Feb 11, 2017
[beta] Backporting PRs to beta

This is a backport of the following PRs:

* #39478
* #39509
* #39517
* #39526
* #39599
* #39624
* #39710
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants