Uninhabited while-let pattern fix #39526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
|
Does this need to be backported? cc @rust-lang/compiler |
arielb1
added
the
beta-nominated
|
@arielb1 All done. |
|
@bors r+ |
|
📌 Commit 7135d0a has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 5, 2017
… r=arielb1 Uninhabited while-let pattern fix This fix makes it so while-let with an unsatisfiable pattern raises a correct warning rather than an incorrect error.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 5, 2017
… r=arielb1 Uninhabited while-let pattern fix This fix makes it so while-let with an unsatisfiable pattern raises a correct warning rather than an incorrect error.
|
@eddyb You mean backported to beta? Probably, yes. |
nikomatsakis
added
the
beta-accepted
|
Approved for beta backport: small, isolated change; regression. cc @rust-lang/compiler |
brson
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Feb 11, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix makes it so while-let with an unsatisfiable pattern raises a correct warning rather than an incorrect error.