-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[LLVM 4.0] Use 32-bits for alignment #39529
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
LLVM 4.0 changes this. This change is fine to make for LLVM 3.9 as we won't have alignments greater than 2^32-1.
(rust_highfive has picked a reviewer for you, use r? to override) |
All those casts make me uneasy. The functions called and variables used should become u32 in the first place IMO. |
Yes, rustc should just follow LLVM's example and always compute and store alignments as 32 bit numbers. |
There are two cases of casts that I've touched
|
I think it makes sense to change |
@rkruppe: I've removed all of the casts. It turns out that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! r=me, unless the people with bors rights would rather see @nagisa confirm.
Ping |
@bors: r+ |
📌 Commit c7bea76 has been approved by |
…crichton [LLVM 4.0] Use 32-bits for alignment LLVM 4.0 changes this. This change is fine to make for LLVM 3.9 as we won't have alignments greater than 2^32-1.
…crichton [LLVM 4.0] Use 32-bits for alignment LLVM 4.0 changes this. This change is fine to make for LLVM 3.9 as we won't have alignments greater than 2^32-1.
LLVM 4.0 changes this. This change is fine to make for LLVM 3.9 as we
won't have alignments greater than 2^32-1.