Rollup of 6 pull requests #40053
Closed
Rollup of 6 pull requests #40053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GuillaumeGomez
commented
Feb 23, 2017
GuillaumeGomez
commented
- Successful merges: Set rustdoc --test files' path relative to the current directory #39859, Additional docs for Vec, String, and slice trait impls #39886, Fix indentation of error message #39940, Add missing urls and examples into Barrier structs #40010, Clarify thread::Builder::stack_size docs #40030, Update exception-safety.md #40050
- Failed merges:
So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit.
Fix variable name typo
…e-path, r=alexcrichton Set rustdoc --test files' path relative to the current directory r? @alexcrichton
Additional docs for Vec, String, and slice trait impls r? @steveklabnik
Fix indentation of error message So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit. <img width="680" alt="screen shot 2017-02-18 at 4 35 36 pm" src="https://cloud.githubusercontent.com/assets/1529387/23097087/0ef5ac4a-f5f9-11e6-9132-18ce759f7092.png">
…sxcv Add missing urls and examples into Barrier structs r? @frewsxcv
Clarify thread::Builder::stack_size docs Add two pieces of information: * the size is in bytes * the actual stack size might be bigger. Also change the example to use a more realistic value of 32 kilobytes. r? @steveklabnik
Update exception-safety.md Fix variable name typo
|
@bors: r+ p=1 |
|
📌 Commit c672e06 has been approved by |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit c672e06 with merge 673e11d... |
|
💔 Test failed - status-travis |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.