Skip to content

Fix ICE: don't use struct_variant on enums #40285

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2017
Merged

Fix ICE: don't use struct_variant on enums #40285

merged 1 commit into from
Mar 6, 2017

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Mar 6, 2017

Fix #40221 and add unittest.

@rust-highfive
Copy link
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1
Copy link
Contributor

arielb1 commented Mar 6, 2017

@bors r+

Beta (1.16) nominating because regression.

@bors
Copy link
Collaborator

bors commented Mar 6, 2017

📌 Commit 168122f has been approved by arielb1

@arielb1 arielb1 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 6, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 6, 2017
@frewsxcv
Rollup merge of rust-lang#40285 - estebank:issue-40221, r=arielb1
1d6ec96 
Fix ICE: don't use `struct_variant` on enums

Fix rust-lang#40221 and add unittest.
@frewsxcv frewsxcv mentioned this pull request Mar 6, 2017
Closed
@bors
Copy link
Collaborator

bors commented Mar 6, 2017

🔒 Merge conflict

@frewsxcv
Copy link
Member

frewsxcv commented Mar 6, 2017

@bors r-

There's an error with these changes

https://travis-ci.org/rust-lang/rust/jobs/208042795

@estebank
Copy link
Contributor Author

estebank commented Mar 6, 2017

@frewsxcv @arielb1 fixed a typo in the test itself and rebased against master (this is the first time I've seen @bors telling us about merge conflicts, rebased against master without merge conflicts).

@frewsxcv
Copy link
Member

frewsxcv commented Mar 6, 2017

Regarding the merge conflict, it's a bug with Homu/bors, not with your changes.

@frewsxcv
Copy link
Member

frewsxcv commented Mar 6, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 6, 2017

📌 Commit ad06fc7 has been approved by frewsxcv

@estebank estebank mentioned this pull request Mar 6, 2017
Merged
@bors
Copy link
Collaborator

bors commented Mar 6, 2017

⌛ Testing commit ad06fc7 with merge bd62cbf...

bors added a commit that referenced this pull request Mar 6, 2017
@bors
Auto merge of #40285 - estebank:issue-40221, r=frewsxcv
bd62cbf 
Fix ICE: don't use `struct_variant` on enums

Fix #40221 and add unittest.
@bors
Copy link
Collaborator

bors commented Mar 6, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: frewsxcv
Pushing bd62cbf to master...

@bors bors merged commit ad06fc7 into rust-lang:master Mar 6, 2017
@brson brson added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 9, 2017
@brson brson mentioned this pull request Mar 9, 2017
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 9, 2017
bors added a commit that referenced this pull request Mar 9, 2017
@bors
Auto merge of #40401 - brson:beta-next, r=alexcrichton
94dca9a 
Beta next

- #40285
- #40272
- #40064
- #39835
- #40398

r? @alexcrichton
@estebank estebank deleted the issue-40221 branch November 9, 2023 05:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@estebank @rust-highfive @arielb1 @bors @frewsxcv @alexcrichton @brson