Add tests for issues with the 'E-needtest' label. #40296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
petrochenkov
reviewed
Mar 6, 2017
src/test/compile-fail/issue-23311.rs
Outdated
| fn main() { | ||
| match "foo".as_bytes() { | ||
| b"food" => (), | ||
| [b'f', ..] => (), //~ ERROR expected an array or slice, found `&[u8]` [E0529] |
There was a problem hiding this comment.
Rules for slice patterns slightly changed since #23311 was filed.
[b'f', ..] needs to be replaced with &[b'f', ..] to reproduce the old behavior.
|
Thanks @topecongiro! r=me with @petrochenkov's suggestion |
topecongiro
force-pushed
the
add-missing-tests
branch
from
6840f3b to
c1064f6
Compare
|
@petrochenkov Thank you for your comment! EDIT: I realized that after replacing |
topecongiro
force-pushed
the
add-missing-tests
branch
from
c1064f6 to
7dc36e9
Compare
|
@bors r=alexcrichton |
|
📌 Commit 7dc36e9 has been approved by |
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 8, 2017
…excrichton Add tests for issues with the 'E-needtest' label. This PR adds tests for the following issues:
bors
added a commit
that referenced
this pull request
Mar 9, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the following issues:
#15953, #18446, #22874 and #23311.