Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Handle extern functions and statics in save-analysis #40348

Merged
merged 3 commits into from
Apr 5, 2017
Merged

Handle extern functions and statics in save-analysis #40348

merged 3 commits into from
Apr 5, 2017

Conversation

nrc
Copy link
Member

@nrc nrc commented Mar 8, 2017

r? @eddyb

@nrc nrc mentioned this pull request Mar 8, 2017
Closed
@eddyb
Copy link
Member

eddyb commented Mar 8, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 8, 2017

📌 Commit 0aceb99 has been approved by eddyb

@nrc nrc assigned eddyb Mar 9, 2017
@bors
Copy link
Collaborator

bors commented Mar 9, 2017

🔒 Merge conflict

@alexcrichton
Copy link
Member

@bors: retry

arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 9, 2017
Rollup merge of rust-lang#40348 - nrc:save-extern-fn, r=eddyb
d042c51 
Handle extern functions and statics in save-analysis

r? @eddyb
@arielb1 arielb1 mentioned this pull request Mar 9, 2017
Closed
@arielb1
Copy link
Contributor

arielb1 commented Mar 10, 2017 

thread 'rustc' panicked at 'Name not in signature?', /checkout/src/libcore/option.rs:785

note: Run with `RUST_BACKTRACE=1` for a backtrace.

Build failed, waiting for other jobs to finish...

error: Could not compile `rustc_llvm`.

@arielb1
Copy link
Contributor

arielb1 commented Mar 10, 2017

@bors r-

@nrc nrc force-pushed the save-extern-fn branch from 0aceb99 to 4cf22cb Compare March 15, 2017 21:43
@nrc
Copy link
Member Author

nrc commented Mar 16, 2017

@bors: r=@eddyb

@bors
Copy link
Collaborator

bors commented Mar 16, 2017

📌 Commit 4cf22cb has been approved by @eddyb

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
@frewsxcv
Rollup merge of rust-lang#40348 - nrc:save-extern-fn, r=@eddyb
8bc39f8 
Handle extern functions and statics in save-analysis

r? @eddyb
@frewsxcv frewsxcv mentioned this pull request Mar 18, 2017
Closed
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 18, 2017
Rollup merge of rust-lang#40348 - nrc:save-extern-fn, r=@eddyb
8e6afbf 
Handle extern functions and statics in save-analysis

r? @eddyb
@arielb1 arielb1 mentioned this pull request Mar 18, 2017
Closed
bors added a commit that referenced this pull request Mar 18, 2017
@bors
Auto merge of #40644 - arielb1:rollup, r=arielb1
1d565ef 
Rollup of 22 pull requests

- Successful merges: #40241, #40346, #40348, #40377, #40398, #40409, #40441, #40445, #40509, #40521, #40523, #40532, #40538, #40564, #40581, #40583, #40588, #40589, #40590, #40603, #40611, #40621
- Failed merges: #40501, #40541
@arielb1
Copy link
Contributor

arielb1 commented Mar 19, 2017

Still broken, same error:

thread 'rustc' panicked at 'Name not in signature?', /checkout/src/libcore/option.rs:785

note: Run with `RUST_BACKTRACE=1` for a backtrace.

Build failed, waiting for other jobs to finish...

error: Could not compile `rustc_llvm`.

@bors r-

@nrc
Copy link
Member Author

nrc commented Mar 19, 2017

@arielb1 how do I repro this? We're passing everything on Travis and running x.py test locally is fine too.

@arielb1
Copy link
Contributor

arielb1 commented Mar 19, 2017

@nrc

Try doing ../x.py dist.

@nrc
Copy link
Member Author

nrc commented Mar 19, 2017

Nope, dist works fine. This looks like a specific save-analysis error, but the only place (iirc) we run save-analysis in the the test suite is in two tests in run-make - both of which run fine. My only thought is that this is due to a combination of this PR and another one in the rollup? But I don't see anything that would affect save-analysis in the rollup. I've rebased and am running tests again locally to see if I can repro...

@nrc nrc force-pushed the save-extern-fn branch from 4cf22cb to 158079e Compare March 27, 2017 04:11
@nrc
Copy link
Member Author

nrc commented Mar 27, 2017

@bors: r=eddyb

Yet again, I still can't repro any failure with test or dist (which suggests that the problem is not with another PR, but perhaps platform specific?). I don't see any way to debug this further without bors having a run over it. I suppose this will fail and waste some time, but otherwise I'm stuck.

Please don't rollup this PR (or r- it).

@bors
Copy link
Collaborator

bors commented Mar 27, 2017

📌 Commit 158079e has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Mar 27, 2017

⌛ Testing commit 158079e with merge 22ff5e0...

@bors
Copy link
Collaborator

bors commented Mar 27, 2017

💔 Test failed - status-appveyor

@nrc
Copy link
Member Author

nrc commented Mar 30, 2017

@bors: retry

@bors
Copy link
Collaborator

bors commented Mar 30, 2017

⌛ Testing commit 8f6b68c with merge e126c17...

@bors
Copy link
Collaborator

bors commented Mar 30, 2017

💔 Test failed - status-travis

@nrc nrc force-pushed the save-extern-fn branch from 8f6b68c to d76daf5 Compare April 4, 2017 04:08
@nrc
Copy link
Member Author

nrc commented Apr 4, 2017

@bors: r=eddyb

@bors
Copy link
Collaborator

bors commented Apr 4, 2017

📌 Commit d76daf5 has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Apr 4, 2017

⌛ Testing commit d76daf5 with merge 1f41ec8...

@frewsxcv
Copy link
Member

frewsxcv commented Apr 4, 2017

@bors retry

prioritizing rollup

@bors
Copy link
Collaborator

bors commented Apr 4, 2017

⌛ Testing commit d76daf5 with merge e086442...

@frewsxcv
Copy link
Member

frewsxcv commented Apr 4, 2017

@bors retry

prioritizing rollup

@bors
Copy link
Collaborator

bors commented Apr 5, 2017

⌛ Testing commit d76daf5 with merge 3fe451b...

bors added a commit that referenced this pull request Apr 5, 2017
@bors
Auto merge of #40348 - nrc:save-extern-fn, r=eddyb
3fe451b 
Handle extern functions and statics in save-analysis

r? @eddyb
@bors
Copy link
Collaborator

bors commented Apr 5, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Apr 5, 2017 via email

@bors
Copy link
Collaborator

bors commented Apr 5, 2017

⌛ Testing commit d76daf5 with merge d97853a...

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 5, 2017
@frewsxcv
Rollup merge of rust-lang#40348 - nrc:save-extern-fn, r=eddyb
580e8d7 
Handle extern functions and statics in save-analysis

r? @eddyb
@frewsxcv frewsxcv mentioned this pull request Apr 5, 2017
Closed
@frewsxcv
Copy link
Member

frewsxcv commented Apr 5, 2017

@bors retry

prioritizing rollup which includes these changes

@bors
Copy link
Collaborator

bors commented Apr 5, 2017

⌛ Testing commit d76daf5 with merge 91ae22a...

bors added a commit that referenced this pull request Apr 5, 2017
@bors
Auto merge of #40348 - nrc:save-extern-fn, r=eddyb
91ae22a 
Handle extern functions and statics in save-analysis

r? @eddyb
@bors
Copy link
Collaborator

bors commented Apr 5, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 91ae22a to master...

@bors bors merged commit d76daf5 into rust-lang:master Apr 5, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nrc @eddyb @bors @alexcrichton @arielb1 @frewsxcv