travis: Ensure cargo links libcurl statically #40507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want a dynamic dependency in the library that we ship, so link it statically by configuring curl-sys's build script to not pick up the system version via pkg-config.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
This is a regession from nightly, so nominating for beta as well. |
alexcrichton
added
beta-nominated
|
@bors r+ |
|
📌 Commit 5fab9bf has been approved by |
|
@bors: p=1 (fixing nightly) |
alexcrichton
removed
the
beta-nominated
|
⌛ Testing commit 5fab9bf with merge 6d38130... |
|
💔 Test failed - status-travis |
|
@bors: retry
|
|
@alexcrichton Looks like bors failed, could you retry it? |
|
@SirDoctors ah yeah that's what my previous comment is doing. |
bors
added a commit
that referenced
this pull request
Mar 16, 2017
[beta] travis: Ensure cargo links libcurl statically This is a beta backport of #40507
|
⌛ Testing commit 5fab9bf with merge 12cc8da... |
|
💔 Test failed - status-appveyor |
|
… On Thu, Mar 16, 2017 at 9:03 AM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2406>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40507 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95AMudN6LXqS_T6JLceJkJBK2aWR-ks5rmUEpgaJpZM4McIrS>
.
|
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
travis: Ensure cargo links libcurl statically We don't want a dynamic dependency in the library that we ship, so link it statically by configuring curl-sys's build script to not pick up the system version via pkg-config.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
travis: Ensure cargo links libcurl statically We don't want a dynamic dependency in the library that we ship, so link it statically by configuring curl-sys's build script to not pick up the system version via pkg-config.
|
⌛ Testing commit 5fab9bf with merge 2e540cd... |
|
💔 Test failed - status-travis |
|
@bors: retry
|
alexcrichton
added
the
beta-nominated
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
travis: Ensure cargo links libcurl statically We don't want a dynamic dependency in the library that we ship, so link it statically by configuring curl-sys's build script to not pick up the system version via pkg-config.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
travis: Ensure cargo links libcurl statically We don't want a dynamic dependency in the library that we ship, so link it statically by configuring curl-sys's build script to not pick up the system version via pkg-config.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
travis: Ensure cargo links libcurl statically We don't want a dynamic dependency in the library that we ship, so link it statically by configuring curl-sys's build script to not pick up the system version via pkg-config.
bors
added a commit
that referenced
this pull request
Mar 18, 2017
travis: Ensure cargo links libcurl statically We don't want a dynamic dependency in the library that we ship, so link it statically by configuring curl-sys's build script to not pick up the system version via pkg-config.
|
☀️ Test successful - status-appveyor, status-travis |
|
woot! |
alexcrichton
removed
the
beta-nominated
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want a dynamic dependency in the library that we ship, so link it
statically by configuring curl-sys's build script to not pick up the system
version via pkg-config.