Skip to content

Implement std::error::Error for !. #40566

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2017
Merged

Implement std::error::Error for !. #40566

merged 1 commit into from
Mar 20, 2017

Conversation

clarfonthey
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@sfackler
Copy link
Member

@canndrew I sort of remember there being some reason this hadn't already been done? Is there still some blocker?

@canndrew
Copy link
Contributor

canndrew commented Mar 19, 2017 •
edited
Loading

@sfackler Enabling #[feature(never_type)] on libstd was causing shenanigans, but it looks like it's been fixed now.

More specifically: the try function which is used to implement catch_panic would try to call uninitialized::<!> if it was given a closure which returned ! and this would cause it to crash. But it looks like that code has been changed and tests are passing now so I'd say this is probably safe to merge.

@sfackler
Copy link
Member

Cool, thanks.

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 19, 2017

📌 Commit a5cf551 has been approved by sfackler

@frewsxcv frewsxcv mentioned this pull request Mar 19, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 20, 2017
@frewsxcv
Rollup merge of rust-lang#40566 - clarcharr:never_error, r=sfackler
4e90331 
Implement std::error::Error for !.
@frewsxcv frewsxcv mentioned this pull request Mar 20, 2017
Merged
bors added a commit that referenced this pull request Mar 20, 2017
@bors
Auto merge of #40659 - frewsxcv:rollup, r=frewsxcv
244f893 
Rollup of 9 pull requests

- Successful merges: #40241, #40281, #40398, #40521, #40532, #40554, #40566, #40581, #40587
- Failed merges:
@bors bors merged commit a5cf551 into rust-lang:master Mar 20, 2017
@clarfonthey clarfonthey deleted the never_error branch April 1, 2017 17:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@sfackler sfackler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clarfonthey @rust-highfive @sfackler @canndrew @bors