Skip to content

Update the cargo submodule again #40625

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 18, 2017

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Mar 18, 2017

Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!

Closes rust-lang/cargo#3844

Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!
@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

cc @frewsxcv

no worries, just a reminder to be careful on those submodule updates!

Also infra's weekly reminder that a rust-highfive reminder of a submodule update would be useful...

@bors: r+ p=1000

(this is a nightly regression)

@bors
Copy link
Collaborator

bors commented Mar 18, 2017

📌 Commit 9fb737b has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
…alexcrichton

Update the cargo submodule again

Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!
@frewsxcv
Copy link
Member

Ugghh sorry about this :(

@frewsxcv
Copy link
Member

Is it possible we could add a cargo version sanity check before publishing a new version?

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
…alexcrichton

Update the cargo submodule again

Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!

Closes rust-lang/cargo#3844
@bors
Copy link
Collaborator

bors commented Mar 18, 2017

⌛ Testing commit 9fb737b with merge 5f8a4ec...

@bors
Copy link
Collaborator

bors commented Mar 18, 2017

💔 Test failed - status-appveyor

@arielb1
Copy link
Contributor

arielb1 commented Mar 18, 2017

@bors
Copy link
Collaborator

bors commented Mar 18, 2017

⌛ Testing commit 9fb737b with merge 711a17c...

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
…alexcrichton

Update the cargo submodule again

Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!

Closes rust-lang/cargo#3844
@frewsxcv
Copy link
Member

@bors retry

prioritizing rollup which has this

@bors
Copy link
Collaborator

bors commented Mar 18, 2017

⌛ Testing commit 9fb737b with merge 4853584...

bors added a commit that referenced this pull request Mar 18, 2017
Update the cargo submodule again

Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!

Closes rust-lang/cargo#3844
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
…alexcrichton

Update the cargo submodule again

Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!

Closes rust-lang/cargo#3844
@bors
Copy link
Collaborator

bors commented Mar 18, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 4853584 to master...

@bors bors merged commit 9fb737b into rust-lang:master Mar 18, 2017
@alexcrichton alexcrichton deleted the update-cargo-again branch April 4, 2017 23:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants