Skip to content

Make the rustdoc sidebar white on src pages #40888

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2017
Merged

Make the rustdoc sidebar white on src pages #40888

merged 1 commit into from
Mar 31, 2017

Conversation

wesleywiser
Copy link
Member

Fixes #40724

@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Contributor

r? @GuillaumeGomez

(rust_highfive has picked a reviewer for you, use r? to override)

@frewsxcv frewsxcv added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 29, 2017
@GuillaumeGomez
Copy link
Member

Changes look fine. Can you provide screenshot of before and after this change before I approve this PR please?

@wesleywiser
Copy link
Member Author

Sure!

Before:
screen shot 2017-03-29 at 7 36 51 pm

After:
screen shot 2017-03-29 at 7 37 06 pm

@GuillaumeGomez
Copy link
Member

Thanks a lot for this!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 30, 2017

📌 Commit 2040dae has been approved by GuillaumeGomez

@frewsxcv frewsxcv mentioned this pull request Mar 31, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 31, 2017
@frewsxcv
Rollup merge of rust-lang#40888 - wesleywiser:rustdoc_src_sidebar, r=…
488a7b3 
…GuillaumeGomez

Make the rustdoc sidebar white on `src` pages

Fixes rust-lang#40724
@frewsxcv frewsxcv mentioned this pull request Mar 31, 2017
Merged
bors added a commit that referenced this pull request Mar 31, 2017
@bors
Auto merge of #40950 - frewsxcv:rollup, r=frewsxcv
40feadb 
Rollup of 10 pull requests

- Successful merges: #40694, #40842, #40869, #40888, #40898, #40904, #40925, #40928, #40929, #40934
- Failed merges:
@bors bors merged commit 2040dae into rust-lang:master Mar 31, 2017
@alexcrichton alexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 1, 2017
@alexcrichton alexcrichton mentioned this pull request Apr 1, 2017
Merged
bors added a commit that referenced this pull request Apr 1, 2017
@bors
Auto merge of #40995 - alexcrichton:beta-next, r=alexcrichton
b37cc75 
Backport PRs to beta

Backport of

* #40967
* #40836
* #40779
* #40888

Also includes a cargo submodule update
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wesleywiser @rust-highfive @GuillaumeGomez @bors @alexcrichton @frewsxcv