Skip to content

Do not recommend private fields called as method #41062

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2017
Merged

Do not recommend private fields called as method #41062

merged 1 commit into from
Apr 5, 2017

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Apr 4, 2017 

error: no method named `dog_age` found for type `animal::Dog` in the current scope
  --> $DIR/private-field.rs:26:23
   |
26 |     let dog_age = dog.dog_age();
   |                       ^^^^^^^ private field, not a method

Fix #27654.

@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1
Copy link
Contributor

arielb1 commented Apr 4, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 4, 2017

📌 Commit 3409f8d has been approved by arielb1

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 4, 2017
@frewsxcv
Rollup merge of rust-lang#41062 - estebank:private-field, r=arielb1
995c946 
Do not recommend private fields called as method

```rust
error: no method named `dog_age` found for type `animal::Dog` in the current scope
  --> $DIR/private-field.rs:26:23
   |
26 |     let dog_age = dog.dog_age();
   |                       ^^^^^^^ private field, not a method
```
Fix rust-lang#27654.
@frewsxcv frewsxcv mentioned this pull request Apr 4, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 5, 2017
@frewsxcv
Rollup merge of rust-lang#41062 - estebank:private-field, r=arielb1
3d566ad 
Do not recommend private fields called as method

```rust
error: no method named `dog_age` found for type `animal::Dog` in the current scope
  --> $DIR/private-field.rs:26:23
   |
26 |     let dog_age = dog.dog_age();
   |                       ^^^^^^^ private field, not a method
```
Fix rust-lang#27654.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 5, 2017
@frewsxcv
Rollup merge of rust-lang#41062 - estebank:private-field, r=arielb1
1b6d25b 
Do not recommend private fields called as method

```rust
error: no method named `dog_age` found for type `animal::Dog` in the current scope
  --> $DIR/private-field.rs:26:23
   |
26 |     let dog_age = dog.dog_age();
   |                       ^^^^^^^ private field, not a method
```
Fix rust-lang#27654.
@frewsxcv frewsxcv mentioned this pull request Apr 5, 2017
Merged
bors added a commit that referenced this pull request Apr 5, 2017
@bors
Auto merge of #41086 - frewsxcv:rollup, r=frewsxcv
46f71a0 
Rollup of 19 pull requests

- Successful merges: #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049, #41062, #41066, #41076, #41085
- Failed merges:
@bors bors merged commit 3409f8d into rust-lang:master Apr 5, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@estebank @rust-highfive @arielb1 @bors @pnkfelix