Skip to content

Make sccache a bit quieter #41209

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Conversation

aidanhs
Copy link
Member

@aidanhs aidanhs commented Apr 10, 2017

...and remove the single mention of SCCACHE_LOG_LEVEL that would only take effect on Docker (i.e. Linux) builds since it had no effect anyway (because RUST_LOG takes priority).

r? @frewsxcv

@aidanhs
Copy link
Member Author

aidanhs commented Apr 11, 2017

r? @alexcrichton

(per the IRC ping). As a data point, if a build has no sccache errors at all then the output of sccache.log goes from >10000 lines to about 3, plus we'll still get fatal errors.

@alexcrichton
Copy link
Member

@bors: r+

Looks grea, thanks!

@bors
Copy link
Collaborator

bors commented Apr 11, 2017

📌 Commit f297767 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 11, 2017
…richton

Make sccache a bit quieter

...and remove the single mention of `SCCACHE_LOG_LEVEL` that would only take effect on Docker (i.e. Linux) builds since it had no effect anyway (because [`RUST_LOG` takes priority](https://github.com/mozilla/sccache/blob/ec10cdb2ddeb3dde9891bea1fa095e504a60a28a/src/main.rs#L124-L128)).

r? @frewsxcv
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 11, 2017
…richton

Make sccache a bit quieter

...and remove the single mention of `SCCACHE_LOG_LEVEL` that would only take effect on Docker (i.e. Linux) builds since it had no effect anyway (because [`RUST_LOG` takes priority](https://github.com/mozilla/sccache/blob/ec10cdb2ddeb3dde9891bea1fa095e504a60a28a/src/main.rs#L124-L128)).

r? @frewsxcv
bors added a commit that referenced this pull request Apr 12, 2017
Rollup of 8 pull requests

- Successful merges: #40377, #40559, #41173, #41202, #41204, #41209, #41216, #41231
- Failed merges:
@bors bors merged commit f297767 into rust-lang:master Apr 12, 2017
@aidanhs aidanhs deleted the aphs-quiet-sccache branch April 12, 2017 10:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants