[rustbuild] Side-step HashMap iteration to preserve command-line step order. #41308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
added
S-waiting-on-review
|
@bors r+ |
|
🔑 Insufficient privileges |
|
@bors r=nagisa |
|
📌 Commit c597994 has been approved by |
|
⌛ Testing commit c597994 with merge fef1026... |
bors
added a commit
that referenced
this pull request
Apr 16, 2017
[rustbuild] Side-step HashMap iteration to preserve command-line step order. The new `HashMap` was introduced by #41227 and it accidentally randomized step order. r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
HashMapwas introduced by #41227 and it accidentally randomized step order.r? @alexcrichton